johnsarie27 / awsautomation Goto Github PK

https://github.com/johnsarie27/AWSReporting/blob/88e505075771e93e5c953852e6d5989a39065a70/Get-ELB.ps1#L71

Add SG's back in here and below in the ELB2LoadBalancer.

https://github.com/johnsarie27/AWSReporting/blob/895c74877861c694da0bb255c6b747eee7eeca70/Initialize-AWSProfile.ps1#L101

Add an | Out-String to end of line?

Description

When entering the secret key the key value can be seen and may be saved in PS history. This should be masked on input

Code

Description

AWS IAM is a region-less (i.e., global) service and should not require region to be specified. The "Region" parameter could/should be removed.

Note: Research and thorough testing is required!

Code

https://github.com/johnsarie27/AWSReporting/blob/2717a35c8bc3ec92fd4052ae92bc3312146ca3e9/Disable-InactiveUserProfile.ps1#L1

Add parameter "ReportOnly" to output objects that would have been removed? Or the opposite parameter called "Force" or something.

Minor issue only. The release version on this repo doesn't match the ModuleVersion in the .psd1. I had trouble importing this because I used the incorrect version number in the module path.

looking to leverage this automation, but keep running into a situation where running:
Remove-LapsedAMI -ProfileName tst2 -Region us-east-2 -BackupSuffix '' -DailyBackupRetentionPeriod 30 -RunAsTestOnly:$false

all it does it displays what it would of removed, doesn't actually issue the commands inside:

            # SETUP SPLATTER TABLE FOR PARAMETERS
            $Splat.Remove('Owner'); $Splat['bolRunAsTestOnly'] = $RunAsTestOnly

            # UNREGISTER AMIS
            if ( $DailyImagesToDelete ) { Unregister-EC2AmisandSnapshot @Splat -amisTargetedForDeletion $DailyImagesToDelete }
            if ( $WeeklyImagesToDelete ) { Unregister-EC2AmisandSnapshot @Splat -amisTargetedForDeletion $WeeklyImagesToDelete }
            if ( $MonthlyImagesToDelete ) { Unregister-EC2AmisandSnapshot @Splat -amisTargetedForDeletion $MonthlyImagesToDelete }

Description

The function Read-Input seems to be an unneceesary rapper for Read-Host and should be removed.

Code

(also on lines 101, 106, and 110)

How should this function be used?
Should the user pass in the user list? Or just the user names?
How are we currently using it?

Description

When using Get-S3Url and trying to paste that into CloudFormation to perform a stack update I get an error message saying the URL isn't valid. When I manually go to the template in S3 and copy the URL directly, it appears to only have one difference - no region in the URI.

Request

Update the function to remove or make the region an optional component of the overall URI.

https://github.com/johnsarie27/AWSReporting/blob/2717a35c8bc3ec92fd4052ae92bc3312146ca3e9/Disable-InactiveUserProfile.ps1#L75

Move the $TimeSpan into the if statement rather than creating a new variable.

Description

Automatically text, analyze, and build new releases.

Tasks

• move type files into private folder