Comments (5)
Hi there - right now, as I'm sure you're aware, all the images used in this library are actually base64 encoded png images. I did this to make sure there wouldn't be any compatibility issues with any browsers, and to stop the need for any external calls on library load.
Before continuing the discussion - I just wanted to confirm that you were aware of this - and also to confirm that what you're asking is to use base64 encoded svg's instead of base64 encoded png's. Is this correct?
from file-upload-with-preview.
Thanks for your answer. Yes, first the quality on my 4k display was my main issue, then I did scan the code and that's where I got concerned about the file size.
I think using basic svg, or even advanced svg with animations and everything is pretty pretty safe now.
Also I don't think you need to encode svg, since it's just xml, you can store it as string or put it in html or make it on the fly.
from file-upload-with-preview.
Ok cool. Yea I think there are benefits to both ways. I think this ties into your other suggestion about the customization object - #17 - perhaps the best way to tackle this would be to let users provide their own images. That way they can go any direction they want.
What I'm going to do is leave this issue open for now, while we tackle the customization object - that should fix this issue as well.
from file-upload-with-preview.
Yes, the ability to change images would fix the HD display issue, but if we want to significantly reduce the file size we need to use svg as default. I can provide you with svg images if you couldn't find free svg's on the web.
from file-upload-with-preview.
Closing this now, updates referenced in issue #17
from file-upload-with-preview.
Related Issues (20)
- How to implement with Angular? HOT 2
- [FEATURE] Ability to set a "main image" HOT 2
- presetFiles doesn't work with base64 encoded binary image string HOT 4
- file-upload-with-preview & Compressor.js HOT 3
- How to access already added images while editing a form? HOT 2
- FileUploadWithPreview is not a constructor (extended with examples) HOT 2
- May I use html_form submit to backend? HOT 2
- how to capture the event with jquery? HOT 1
- There is no name attribute to get the image on backed HOT 4
- Beginner overloaded HOT 2
- Can I use this inside react [just react] ? HOT 2
- Name attribute not present in sending request to server. HOT 6
- file_upload_with_preview__WEBPACK_IMPORTED_MODULE_4__.FileUploadWithPreview is not a constructor HOT 4
- Use in Next js and Tailwind HOT 3
- bug on chooseFile label HOT 2
- Question: can I attach event to element, not to window? HOT 12
- Save in local storage HOT 2
- How to attach to previously initialized instance of FileUploadWithPreview? HOT 4
- How to dynamically click the clear button? HOT 1
- Added event confusion with presets and new add HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from file-upload-with-preview.