johnathonkoster / math Goto Github PK

I've tried for long...but didn't got how to setup this package in laravel 4, please specify the installation steps for this bundle.

The solution engine shouldn't rely on a switch statement to select the function. This would mean that developer's would have to hack the solution engine if they added new functions to their driver.

The default EvalMathEngine is not registered user-defined variables.

The default EvalMathDriver should support the % modulus operator.

The EvalMathDriver is not accepting function names.

Its been a few months since laravel is upgraded to 4.1, please update your library to provide support for laravel 4.1.

The EvalMathDriver is treating the subtraction operator as a negation operator. It performs the subtraction, but also applies the negation operator.

Hi Johnathon,

Just read through your solve method and spotted something which looks like a bug:

https://github.com/JohnathonKoster/math/blob/master/src/Flare/Math/Drivers/EvalMathDriver.php#L159

$temp  = $this->evaluatePostfixNotation($this->convertInfixToPostfix($matches[2]));
            if (($temp = false) == false)
            {
                return false;
            }

The IF block looks incorrect there. Not ran the code, but just thought I'd drop you a line.

I want to used this library in my project which is based on laravel 5.3. Can you please upgrade this library to support laravel 5.3 version.

The ExecutionEngineInterface should define the following functions:

• add
• subtract
• multiply
• divide
• mod

By doing this, the arithmetic operators can be removed from the EvalMathDriver