Git Product home page Git Product logo

pe's Introduction

Hi, I'm Yin Joe 🤠

📖 About me

  • Software engineer with bold ideas
  • Passionate Computer Science and Mathematics student at the National University of Singapore, graduating in May 2025
  • Curious logician (INTP) who loves puzzles and strategy games
  • Run npx joeng03 to download my business card!

🔭 I'm currently working as:

  • Lead Backend Engineer at Google Developer Student Clubs NUS, developing a Volunteer Management System for Ground-Up Initiative, a non-profit organization
  • Software Engineer at NUS Fintech Society
  • SAP Digital: Student Ambassador
  • Software Engineer Intern at GIC

🛠️ My skills:

Frontend:

My Skills

Backend:

My Skills

DevOps:

My Skills

🌱 I’m currently learning ...

Rust

👯 I’m looking to collaborate on:

✅Open Source Projects!
✅Internships!

📫 How to reach me:

pe's People

Contributors

joeng03 avatar

Watchers

 avatar

pe's Issues

Incorrect Definition of Prescription in Glossary

image.png
The definition
Prescription: Uniquely identified by a medication and a start date.
is incorrect as prescription is uniquely identified by medication (medications with the same name are not allowed) and the start date does not uniquely identify the prescription.

Confusing Message for listCompleted

image.png

image.png

The message "Listing all prescriptions that were completed." is confusing because it gives the user the impression that the process is still ongoing, while in reality, it has already been completed. There exists other instances in the application where the past tense is used.
A better message could be to use the past tense, i.e. "Listed all prescriptions that were completed."

Inaccurate Error Message for Untake

image.png

When provided with a negative dosage, the system prints the error message "Dosages should only contain numeric characters, and it should not be blank."

This is slightly inaccurate and may cause confusion for the users as the dosage entered is indeed numeric (but negative) and not blank. A better error message should mention that negative dosages are not allowed.

Inconsistent Error Message for Invalid Indices for edit command

image.png

image.png

image.png

When provided with invalid indices for the edit command, the system returns different error messages.
"Invalid command format" for 0 and negative numbers, "The prescription index provided is invalid" for positive numbers larger than the total number of items. This can potentially be confusing to users.

Incomplete Instructions for Manual Testing in Developer Guide

image.png

image.png

The "Instructions for Manual Testing" section only consists of 3 parts: Launch and shutdown, Deleting a medication, and Saving data. This is highly incomplete and significantly impedes testing efforts as the reader is not provided with instructions for all (or at least most) of the commands in the application, as shown below:

image.png

UI Display is not User-friendly

image.png

Instead of printing all the prescription data in one line, the system should have displayed each attribute in one line, otherwise, it significantly affects the readability of the data.

Confusing Message for listConflicts

image.png

When there are no existing conflicts for an existing drug, and the user enters the listConflict command for a drug, the system prints out "Here are the conflicting drugs." (and no further elaboration).

This is slightly confusing for the user as they are not immediately sure that there are actually no conflicting drugs for this particular drug. A better message could be "There are no conflicting drugs for this drug."

Scrollbar shown in the User Guide, but Unable to Scroll

image.png

For some long examples in the User Guide, a scrollbar is shown, giving the user the impression that is is scrollable, but the user is unable to scroll with either their mouse or keyboard. This slightly affects the cosmetics of the User Guide.

No Support for Checking whether Conflicting Drugs Exist

When using the cfdg/ prefix to add or edit prescriptions in the system, there is no way to validate against any type of user input whatsoever. This could be the source of a lot of bugs due to data entry errors as the application scales. One approach could be to create another model for BayMeds to store valid drugs (with valid names) and check whether the conflicting drugs entered exists in the current list of valid drugs under BayMeds.

AddressBook not Renamed to BayMeds

image.png

Since the folder name is not edited in the code, and the Developer Guide shows the "address", folder, this may be confusing the reader as this application is about medications and there is no mention of address as an input data or name for object.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.