joekarlsson / bechdel-test Goto Github PK

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• 🙋 Claim this issue: Comment below.

  Once claimed we add you as contributor to this repository.

• 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue

• 📝 Update the file src/app/films/NewFilm/NewFilm.js in the bechdel-test repository (press the little pen Icon) and edit the line as shown below.

@@ -10,7 +10,7 @@ const NewFilm = () => {
 				<Uploader />
 			</ErrorBoundary>
 			<p>
-				Note: This tool currently only suppports scripts with a .txt format, and
+				Note: This tool currently only supports scripts with a .txt format, and
 				the script must follow the{' '}
 				<a target="blank" href="http://www.simplyscripts.com/WR_format.html">
 					Standard Script Format

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can edit files directly in your browser

• 🏁 Done Ask in comments for a review :)

🤔❓ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

https://github.com/gotwarlost/istanbul

I've selected helper.js:containsPatriarchalKeywords for refactoring, which is a unit of 54 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

https://api.themoviedb.org/3/movie/tt1800241/images?api_key=6ec9ddad40a319b47c562e0838f7eda3&language=en&include_image_language=en,null

https://image.tmdb.org/t/p/w300/mhB7C62lSMpGO2HYNaW6d7W3TVH.jpg

Promises are currently swallowing my errors - which is making my code super hard to refactor - add buebird Promise.onPossiblyUnhandledRejection(function(error){
throw error;
});

http://jamesknelson.com/are-es6-promises-swallowing-your-errors/

http://ditrospecta.com/javascript/react/es6/webpack/heroku/2015/08/08/deploying-react-webpack-heroku.html

It should be easier for new maintainers to get up and running, and the first time you have to get mongodb up and running locally.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The engines config in 1 of your package.json files was updated to the new Node.js version

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Add search bar to header and make it easy to find any film you are looking for.

Possible third party integrations are possible, but this could be potentially done all with code.

Need to install Babel so I can use fancy new ES6 and ES7 stuff.

I've selected Film.js:Film.renderFilm for refactoring, which is a unit of 47 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

I've selected URLFormatter.js:createSimpleDataURL for refactoring, which is a unit of 34 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Limit the length of code units to 15 lines of code.
• Why❓
  Small units are easier to analyse, test and reuse.
• How 🔧
  When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯