joaomgcd / joinchrome Goto Github PK

Right now .device is set to 70px. With the current width of the window it allows for 5.85 icons. If we drop that a few pixels we can get in another device icon on the line. Before and after pics below.

Thoughts?

Not sure what to make of this. The SMS feature of the chrome app seems entirely nonfunctional for me. It doesn't search or list any of my contacts. Yet all systems are go in the diagnostics of both the Android app and the chrome app.

Chrome app is 1.5.3.
Android is beta 1.5.2b.bf
I use Textra for texting but otherwise the phone is totally stock.. brand new Nexus 6P

Sync contacts/SMS successful

Everything in Chrome passes

I've run a diagnostic and I can't connect to Join server. Do you know what's happening?

I can't push links to my phone anymore by right-clicking on them. This was a vital feature of Join and I would like it back.

I am having issues with the chrome plug-in (Chrome v56 dev).
When i test using the Diagnostics tab:

When i want to rename a device (the chrome) one, nothing happens when i click the button.

When i want to send a page /download to my mobile device, nothing happens either.

I uninstalled the chrome plugin and reinstalled. no effect.

Installed join on a new pc today, the css is all weird, colours are missing:

inspected the css:

Can see you're using var(), this is a University PC so chrome 47 is the newest version and i cant do a whole bunch about it, maybe a bit early to be using what's still an experimental feature? I appreciate 47 is a pretty old version of chrome as chrome versions go, but it's still only 6 months old so maybe a fallback would be appropriate.

Either way, reporting so you know.

J

If I blast off a text from my phone in the default Samsung messaging app while I have a pop-up for sms open, then hit refresh, it won't show what I've sent. Also having to refresh it constantly just to see incoming messages is quite annoying.

Would love an option when you get a Groupme notification to bring you to https://web.groupme.com/chats

I'm running into an issue with the most recent update to the Join chrome extension. The extension lets me select a different base theme (for example, "Normal") but it always reverts back to "Automatic" after closing the window. However, the accent color works as intended.

The image preview is hidden behind the attachment and emoji buttons.

See Below:

The Call button is too easy to mistakenly press when attempting to click on a message.

This is because the smscontactcall div is too large. I send a PR in regards to this shortly.

My external HDD is NTFS, and my local filesystem is ext4. I was having an odd problem that whenever I connected an external USB HDD for a local backup on my Debian Stretch system, the entire system would lock up.

Unplugging the drive would return the system back to normal. After a lot of trial and error, it seems to be the Join files causing everything to lockup.

If you then log into Windows 10, delete the Join folder on the external HDD, and then log back into Debian Stretch, the problem goes away. Until the next time you backup/sync Join folders to the external HDD.

Those files can also create errors when using a program such as FreeFileSync. It can't seem to handle them. I've also had trouble renaming or editing individual SMS files in Windows.

Would it be possible to set shorter filenames?

Steps to reproduce the issue

Copy/sync the Join folder (with SMS files/messages) to an external USB HDD (possibly using NTFS?) on Linux Debian Stretch.

Unplug/plug the external USB HDD.

What I expected

Drive is mounted normally.

What happened instead

System locks up and external USB HDD blinks endlessly indicating that the drive is being accessed.

I was hopeful to use this app but I can't opt out of giving it access to Google Drive. I have sensitive files in there and would rather use the extension without this feature.

If you popout the window, change zoom, then open the popup again it'll look like this.

Interestingly it looks OK in the popout :)

Hi,

I'm using 1.7.6 version of Chrome extension (Chrome dev channel, v61.0.3135.5) along with 1.7.bf version of the Android app.
Chrome extension is configured with the "Dismiss everywhere" option disabled.

Up until recently, after the timeout defined under "Number of seconds a notification should show", Chrome's notification toast disappeared, but the actual notification (as in Android notification, not Chrome notification) was still available - in the extension popup and, most importantly, on my phone.

For some time (a week?) the notifications began to be dismissed, as if I explicitly clicked the close button on notification toast, as soon as Chrome notification toast is dismissed.

While enabling "Keep notifications until you interact with them" prevents notifications from being unnoticed at all, it's impossible to interact with notifications that expose multiple actions. Once the popup that lists these actions appears, the notification toast is dismissed - and the original notification is dismissed with it, so the popup shows "No notifications".

If it's something specific in the way Chrome started to handle notification toast events, then I guess the "Dismiss everywhere" option should not be optional anymore.
Otherwise, it's some kind of regression.

Hello,

I've noticed this bug for a while now but it's finally gotten to me.
As it stand, if I click the extension icon, click my phone, and hit "send a file to your device." I can pick a file from my file system but it won't send.
However, if I first it the popout window then it will send fine.

Any chance we could fix this? :)

A microphone icon appears with the text "Google Chrome is using your microphone, Join" on my mac's top toolbar. Voice Control is disabled under Join's options.

For some reason, no devices are loaded in the chrome extension.

The following error shows up in the console:
Uncaught TypeError: Cannot read property 'where' of null at HTMLDocument.<anonymous> (chrome-extension://flejfacjooompmliegamfbpjjdlhokhj/options.js:266:29)

The extension's setting page shows the device as "undefined" and no photo for the avatar.
I am able to access all the features through the website at: https://joinjoaomgcd.appspot.com/

I haven't dug into the code enough to pinpoint the issue, but a guess is that the extension is not handling multiple google account sign-ins properly. I'm currently signed into 4 google accounts.

I have downloaded the latest source code for the extension and loaded it manually and get the same error message and result.

I am running Chrome Version 54.0.2840.98 (64-bit) on macOS Sierra

If notifications are closed via mouse they will continue to work. If the touch screen is used to swipe or clear notifications then it causes all notifications (including system and other apps) to stay behind the window and not appear. Count will increase in the notification center and you can manually check the notifications but the no longer popup in front. I've been able to reproduce this many times. Problem persists even after Powerwash/extension reinstalls.

running Version 62.0.3202.97 (Official Build) (64-bit), Acer CB5-132T

mta: added OS/hardware

OS: Windows 10 & OSX 10.14
Chrome version: 74 (has been happening for many versions)

Steps to reproduce:

1. Click the icon for Join to open the pop-out.
2. Go to the SMS tab and click on a conversation.
3. Start typing a message.

What should happen: UI should update on every keypress
What actually happens: UI freezes for many seconds and eventually updates after you've typed enough characters, pressed enter to send the message, or performed some other action like clicking on the emoji button.

Additional information:

• This doesn't happen when Join is in its own separate window, only when it's in a pop-out.
• It happens roughly every 32 keypresses if I just press the numbers 0-9 over and over, and roughly every 38 kepresses if I use a-z, although there may be other factors that force a re-draw of the screen.
• This happens even if I'm in the Chrome new-tab page, on github, reddit, etc.
• This behaviour stops happening when I profile the extension with the "screenshots" toggle enabled.
• Profiling doesn't show anything obvious, like rendering taking multiple seconds, but I'm not a web developer
• If I make a single keypress and wait for a full minute the UI doesn't update

Let me know if there's any other information I could give you.

I do not want Join to automatically open all URLs I send to Chrome, it's annoying in many ways.
I want it to just leave them as a notification, but the Android app has no option to send URLs like that (even if you garble them, Join on Chrome still tries to open an intentionally broken URL, which results in an error page).

I would greatly appreciate this feature. Save me from this suffering.

The Perform Favorite Command shortcut does not work, but the shortcuts for all the other configurations do work.

Hi, my girlfriend and I are kind of ridiculous and send lots of emojis. It can be a pain when the extension closes out each time after an emoji is inputted. There should probably be an option to keep it open until the user manually closes it.

PS There are some missing emoji's, mainly the heart - which is gonna put me in hot water eventually.
Is there a technical reason for the limited amount of emojis? And is there also a technical reason why half of them seem to be vehicles?

I may work on this issue later given my classes let up for a bit

The file sent and downloaded perfectly. But afterwards I get this issue when opening the extension. I should also mention that I am using the Github commands version (unpacked extension)
I did uninstall and try it again with chrome store version, no problem

Error screenshot: https://satori-design.d.pr/uLqPHB

Mac OSX Sierra
Chrome Beta latest

when installing the extension, it's not possible to login (login page doesn't appear)
also when checking the settings page none of the buttons/actions/tabs respond when clicking on them

Firstly I would like to give a huge thank you for the app. I've just used it a couple of days but already enjoying it immensely.

I juggle on a daily basis around 6 Google Inbox account and when I get an notification I'd like it to open the correct Inbox, not the default account. It's confusing and slightly annoying.

Have I missed something that I need to configure or is this feature missing? If so would it be possible to implement this feature?

Cheers again!

Hello,

For some reason when I get texts and open them in Join for Chrome, it occasionally will delete the text message. For some reason the texts in Join are not syncing properly with the texts on my phone and Join is overwriting the texts on my phone so now I can't use the text feature without worrying about losing my texts. Any idea how to fix this?

Is there a reason why the legacy text shadow is still being used on #appname ?

Chrome 58.0.3029.110 (64-bit)

Instead of opening shared links or downloading shared photos, it opens a URL in Chrome like this whenever I share stuff from my Android:

chrome-extension://flejfacjooompmliegamfbpjjdlhokhj/<base64(?) data>===:=<more base64(?) data>=

The page itself seems to be a 404 page.

This has been an issue since about a month or two ago (I use Join infrequently).

Join Chrome version 1.7.1
Chrome version 58.0.3029.110 (64-bit)
Windows 10

Join Android version 1.7.bf
Android 6.0.1
HTC 10

User cannot add emojis or attachments while the extension in NOT in popout view.

Prompts infinite Google account sign-ins.

Returning the "key: " line fixes it.

In this case 'This Device' was renamed from 'Chrome' to 'Chrome Work'.

Following the rename the device was moved from being listed second to being listed where it would fall in a natural alphabetical order based on the new given name.

I believe the real issue here is that 'This Device' is being sorted naturally based on the actual name and not being forced to list first.

I use a dark theme on Google Chrome and I can't see the icon on my taskbar. It completely blends in with the background. Example: https://i.imgur.com/txNTWzR.png

Any way we can have the option to use a dark or light icon?

Loving this app and glad to see the Chrome extension got open-sourced!

One issue I've been having is that I'll halfway compose an SMS, return to a webpage (for instance to copy a link to paste into that text) and then click again to return to the Join popover and my halfway composed message is gone.

Is making them persistent an easy fix?

Cheers.

Hi,

First at all, fantastic app, thanks a lot for your work.

I'd like to report an XSS vulnerability that could lead in security issues.
The use of innerHTML in notifications.js and many other files (grep -rnw . -e 'innerHTML') to display notifications/messages/etc is insecure.
Even tough innerHTML does not execute JavaScript, it does load iframes, so a malicious attacker could send you a WhatsApp message or similar with this structure:

<iframe src="http://evil.com"></iframe>

To remote execute code in your notification tab like for example to display an alert in my example:

Consider use or similar to scape any kind of user input and avoid this problems.

Se the following image

+46706 and 0706 are the same non-contact and the same number.
I first sent the text via Join and then got a response.
On the phone the conversation is merged.
On join it is separated.

Kinda like this: http://imgur.com/bViem9B

RIght now it opens in a new tab full width. What if any plans do you have for it?

The console throws errors and some functionality is broken.

The errors first show up in this commit: 887d3d7
887d3d7 because of the inclusion of the extensions.js file in devices.html. The removal of these specific lines fixes the error:

Object.prototype.applyProps = function(objToApply){
if(!objToApply){
return;
}
for(var prop in objToApply){
var value = objToApply[prop];
if(value && value.toClass() != "[object Function]"){
this[prop] = value;
}
}
return this;
};
Object.prototype.toClass = function(){
return {}.toString.call(this);
};
Object.prototype.isString = function(){
return this.toClass() == "[object String]";
};
Object.prototype.isArray = function(){
return this.toClass() == "[object Array]";
};

Even though these lines and extensions.js have existed for several commits, the errors only occur once you import it into devices.html.

Changing the import order of your JS file and the materialize libraries in devices.html resolves one kind of error but introduces a new kind.

Sorry I'm not sure what the code does so I can't really suggest solutions, but I've gotten as much info as I can.

I am not sure if this is a bug on my side or this is something which is not covered by the Chrome extension.

Explanation.
Currently, all notifications I am receiving via Join extension on Chrome are styled in the same way as default Chrome notifications. Chrome provides support for native Windows 10 notifications that are integrated with the taskbar.
I am on the latest Windows 10 and Chrome and on my side, this is not supported - all notifications look like this:

My question is: is this some bug on my side or Join does not support native notifications yet?

macOS Sierra
Latest chrome stable
Join 1.7.7

And if I refresh the device list:

I just connected another device to Join before this happened.

When I send a message through the chrome extension, the messages correctly send but do not appear on Textra / Android Messenger at all, and disappear even from the chrome app after the extension is re-opened.

I am running Android 8.0 on Huawei P20

Hello, I have been testing implementing a dark theme on a separate branch.

http://imgur.com/a/nHP2k
Here's what it looks like so far.

There's simply a toggle (http://imgur.com/a/DgbTo) in the options to trigger it.

The colors can be adjusted, I just used some Google-suggested blue-gray material palettes to fill in the colors just to see how it would look. Any suggestions are welcome.

Would be really cool feature to be able to detect when a notification from Facebook messenger is just an SMS and not bring you to the https://www.messenger.com but rather open a reply alert.

With the addition of features I think the design might benefit from some refactoring. For example I can choose one of the 16 options now by scrolling but using a grid layout I can do that without the scroll. This right now is the biggest on mobile devices but with things like EventGhost being added to desktop that's starting to grow.

A lot of other exts are using a wider layout as well. Pushbullet and the new Hangouts are among the few.

One other thing that brought this up for me was the push history. It feels like it should be in the extension itself and making it another tab up top would be nice vs having to select the device and pick from the list. So you would have
Devices Notifications SMS/Phone Push History
Push history would have the devices under it to click on those

Happy to help in anyway I can @mrkevinlin I know you're busy with school but anyway I can help let me know.

I had set the facebook messenger as the default app for SMS but I've since returned to a dedicated app. But I don't receive notifications on chrome when I receive new SMS (I need to click on the refresh button). Do you know what I'm doing wrong?

I experience lots of duplicated sms and random ordered messages with the chrome plugin ..

seems the order could be something with timestamps being incorrect, inserting my messages above some recently received messages

Cannot remove image to send via sms after attaching the image in popout view.

The image attached will also persist when moving from one conversation to another, which may result in accidentally sending an image to someone that was meant for someone else.

Several updates ago, the spacing between the tabs of the extension was reduced, making it feel just a little cramped.

What do you think of increasing the padding on each side back to 8px and shortening the SMS/Phone tab to say "Contacts" only? I think it is a pretty good compromise. It is essentially a list of the most commonly contacted people with their recent messages AND with the option to phone them directly.

http://imgur.com/a/xP5LO