joaoasrosa / dotnet-project-dependencies-analyser Goto Github PK

I noticed a weird behavior I can't pinpoint exactly.
When I include version 2.0.0 in my Cake script it runs perfectly fine on Windows.

#addin "nuget:https://www.nuget.org/api/v2?package=Cake.DependenciesAnalyser&version=2.0.0"

 Task("Analyse-Dependencies")
     .Description("Runs the Dependencies Analyser on the solution.")
     .Does(() =>
{
     var settings = new DependenciesAnalyserSettings
     {
         Folder = "./"
     };
     AnalyseDependencies(settings);
});

However, when this is included and Cake starts on a UNIX system, the compiler starts complaining.
Removing the above code resolves the issue immediately.
I'll have a more in depth look when I've got more time but I wanted to let you know as that can take a while 😄
You can see the issue here: https://ci.appveyor.com/project/JanJoris/dotnet-core-sample/build/1.0.18/job/ijjicjy5joieu8jn

It would be nice if this addin could provide an Issue Provider for the Cake.Issues addin.
By doing this it could be used together with the other Cake.Issues addins, which for example provide reports or possibility to report issues as comments to pull requests.

Great work on getting this addin created!

This is just a suggestion, but think it would be a really good idea, to help with visibility of this addin.

i.e. get your addin listed here:

http://cakebuild.net/addins

Have a look at this PR:

cake-build/website#290

This assumes that you have added XML Documentation to your addin, as described here:

http://cakebuild.net/docs/contributing/documentation

Let me know if you have any questions. Thanks!

Enhance the plugin to allow to output the report as HTML.
It will allow the CI server to publish it as artifact.

The System.Net.Http is missing from the Addin.

Could not load C:\Repos\nppxmltreeview\tools\Addins\Cake.DependenciesAnalyser.2.0.0\lib\netstandard2.0\NuGet.Protocol.dll (missing System.Net.Http, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a)

Currently, it only analyses the public NuGet feed.
The addin should be capable of analyzing private feeds.
It should rely on the configured NuGet feeds on the local machine.

When a project doesn't have dependencies, report it.
Makes clear what is in the project.

Currently, we do not know if the addin ran, have an error, or if the project doesn't have dependencies.

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

• You are currently referencing Cake.Core 0.27.1. Please upgrade to 0.28.0
• The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
• Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.
• The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png</PackageIconUrl>.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

The addin contains XML comments for aliases, but doesn't ship with the documentation XML file. Therefore comments can't be shown on Cake website (e.g. https://cakebuild.net/extensions/cake-dependenciesanalyser/).
To have aliases documented on the Cake website the NuGet package needs to ship with the documentation XML in the NuGet package.

The README should have the expectations, such what the addin does.

Enhance the plugin to allow to output the report as XML.
It will allow the CI server to publish it as artifact.