Comments (4)
waveiron
commented on May 24, 2024
2
@joanllenas Wow, thanks for your great work!
from ngx-date-fns.
joanllenas
commented on May 24, 2024
1
Hi @waveiron ,
Not accepting invalid input values was a decision I made when I started this project, but at this point, I agree that this is not what you expect from a pipe.
I will probably follow a pattern similar to what Angular uses for its pipes:
https://github.com/angular/angular/blob/11.0.3/packages/common/src/pipes/number_pipe.ts#L239
Does that work for you?
For consistency sake, I will apply the same fix to other pipes where it makes sense to do it.
from ngx-date-fns.
joanllenas
commented on May 24, 2024
1
Hi @waveiron
Just released v7 with your suggestion implemented: https://github.com/joanllenas/ngx-date-fns/releases/tag/v7.0.0
Cheers!
from ngx-date-fns.
waveiron
commented on May 24, 2024
@joanllenas That will work, since pipes accept "loose" data in view level. Thanks for your great work.
from ngx-date-fns.
Related Issues (20)
- Pipes isToday, isWeekend, isSameMonth HOT 4
- IsSameYear pipe HOT 3
- Support date-fns-tz HOT 8
- Add dfnsParseIso pipe HOT 2
- Documentation for lazy loaded modules HOT 1
- Support `strictTemplates` / All pipes should accept null and undefined HOT 4
- ngx-date-fns.js depends on 'date-fns/parseISO'. CommonJS or AMD dependencies can cause optimization bailouts HOT 7
- FR: Add *Duration pipes HOT 2
- IsEqual Pipe HOT 2
- "CommonJS or AMD" warnings HOT 9
- Documentation about tree shaking is not correct HOT 2
- FR: dfnsFormatRelativeToNow HOT 4
- is*() functions are missing HOT 5
- What is the amLocal equivalent of ngx-moment? HOT 2
- Angular 13 : "Encourage the library authors to publish an Ivy distribution" HOT 8
- Angular 14 support HOT 7
- Angular 16 support HOT 4
- date-fns 3.x support HOT 5
- Auto-detect language HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-date-fns.