Support date-fns-tz about ngx-date-fns HOT 8 CLOSED

What bothers me is adding another mandatory dependency to the library. I'm not 100% sure about this, but let me take a look first, I haven't used this library myself.

You could add a sub-module in a sub-folder by adding a package.json file like this one:

{
  "name": "ngx-date-fns/tz",
  "private": true,
  "ngPackage": {
    "lib": {
      "entryFile": "./src/public-api.ts"
    }
  },
  "peerDependencies": {
    "@angular/common": ">=8",
    "@angular/core": ">=8",
    "date-fns": ">=2",
    "date-fns-tz": ">=2"
  }
}

from ngx-date-fns.

Example here: https://github.com/ng-packagr/ng-packagr/blob/master/integration/samples/secondary/sub-module/package.json

from ngx-date-fns.

Docs here: https://github.com/ng-packagr/ng-packagr/blob/master/docs/secondary-entrypoints.md

from ngx-date-fns.

Hi @vhdirk, thanks for your suggestion.
What bothers me is adding another mandatory dependency to the library. I'm not 100% sure about this, but let me take a look first, I haven't used this library myself.

from ngx-date-fns.

Thank's @LayZeeDK,
I had no idea this could be done. Researching right know 👍

from ngx-date-fns.

I also found this very detailed article: https://medium.com/tunaiku-tech/creating-secondary-entry-points-for-your-angular-library-1d5c0e95600a
I will look into all of this more thoroughly next weekend.

from ngx-date-fns.

Hey, It's been a long time since this was posted and there hasn't been much interest in this. I'm closing the issue.
Thanks!

from ngx-date-fns.

As it turns out, having dependencies in a secondary entry point isn't supported by any package managers so it wouldn't have made a difference. There are ways to mark peer dependencies as optional in the primary entry point's package.json file though.

from ngx-date-fns.