jnjy / ped Goto Github PK

Should be student instead of students.

Test Command:

student 1A grade in/03 test/CA1 score/75 weightage/10

The test above tries to check for duplicated test result of a student, however, the response message includes Addressbook (remnant from AB3).

Test Command:
student 1A gradedelete in/03 test/CA3 test/CA2

This test is used to check if the user is able to delete multiple tests in one attempt (multiple test deletion). However, this is some food for thought to consider as per user's perspective to easily delete multiple tests/homeworks in a single command.

Running the above test command only resulted in CA2 being deleted but not CA3. The output is as below after the command execution.

Missing the '/' after relationship prefix.

gradedelete in/<INDEX_NUMBER> [test/<TEST_NAME> OR hw/<HOMEWORK_NAME>]

Optional field here does not indicate that the field is optional.

The format of phone number is not fixed and it allows invalid phone number being inserted (if the phone number format follows Singapore's dialer number format). Can add regex expression to check before insertion.

Test command:
student 3A comment in/25 com/Quiet person, needs to interact more with classmates

Running the above invalid command does not give any response message.

Test Commands:

1. student 1A add n/TanAhCow in/03 pn/TanAhNiu pnP/91234567 rls/Father
2. student 1A add n/TanAhCow in/04 pn/TanAhNiu pnP/91234567 rls/Father

The above test checked if a NOK can have multiple student of the same name but different Index under him although the NOK is father for both students.

At the start of the UG mentioned that the square bracket [ ] indicates optional parameter. Screenshot as shown below:

then the format given by Grade is as follows:

However, when keyed in the grade command without the optional field will result in error message being displayed.

This does not abide by the convention that is mentioned in the UG where [params] is optional. Maybe can try to think of alternative way to represent the command format.

Test commands:

1. student 1B add n/son in/01 pn/dad pnP/12345678 rls/father
2. student 1B add n/daughter in/01 pn/dad pnP/12345678 rls/father

The error message is shown as ERROR, operation would result in duplicate students!. It would be more correct if it shows duplicate student index instead unless there is an explanation mentioning explicitly to users that the student index uniquely identifies each student. I am thinking from the perspective of a non-tech-savy user who may not understand the error message.

The placeholder used to indicate empty information can be very distracting if use "Insert .... here".

Can try placeholder like "-" which is easier to the eyes.

Test command:

student 1A grade in/13 hw/homework1 score/75 deadline/25/04/2023 weightage/10 hwdone/true

Insertion of grade for homework allows insertion deadline which is before the current date. In my opinion, insertion of deadline should have deadline in the future.

Clicking on either:

Command Summary for Student
Command Summary for Parent

does not navigate me to the command summary page.

Test command:

• student 1B attendance in/02 att/10/12/2012

The result of attendance in the GUI is still indicated as F instead of showing the date of attendance.