jncrmx / dynamicwallpaper Goto Github PK

Hence the normal wallpaper is visible in the Task Bar. Not sure how to fix this...

This happens if the onlineUsers Map is modified while render(double) iterates over it.

Stacktrace:

Exception in thread "main" java.util.ConcurrentModificationException
	at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445)
	at java.util.HashMap$EntryIterator.next(HashMap.java:1479)
	at java.util.HashMap$EntryIterator.next(HashMap.java:1477)
	at de.jcm.dynamicwallpaper.extra.DiscordOverlay.render(DiscordOverlay.java:306)
	at de.jcm.dynamicwallpaper.DynamicWallpaper.loop(DynamicWallpaper.java:632)
	at de.jcm.dynamicwallpaper.DynamicWallpaper.run(DynamicWallpaper.java:171)
	at de.jcm.dynamicwallpaper.DynamicWallpaper.main(DynamicWallpaper.java:816)

Ideas:

• work synchronized
• clone the Map before iterating over it
• Is there an Iterator that is separated from the Map?

One avatar disappears after some time (probably next update).

• Maybe test if the list already contains the user before adding it to the list?
• Maybe remove duplicate users are the end of each update?

Two reasons:

1. We don't load Discord's 32-bit library. We need to change de.jcm.dynamicwallpaper.extra.DiscordOverlay#downloadDiscordLibrary to fix this.
2. The Java binding library has no 32-bit native libraries. I need to update the library to load 32-bit natives, and actually build and upload those.