Git Product home page Git Product logo

circleci-php-client's People

Contributors

airmanbzh avatar bitone avatar grena avatar jmleroux avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

circleci-php-client's Issues

AddPipelines::execute() method uses wrong API Path

First of all, thank you so much for creating this package!

I believe some endpoints (for v2 API) are wrong though:

In AllPipelines.php, execute() method:

    $uri = sprintf('project/%s/pipeline', $projectSlug);

Should be I think:

    $uri = sprintf('/pipeline?org-slug=%s', $projectSlug);

PHP 8.2 Version constraints

Hi @jmleroux , I have tested this package and it works fine on PHP 8.2, but it has version constraint for PHP 8.1, so I had to composer install with --ignore-platform-reqs flag, but I can't do this in production, so is it possible to improve version constraint so I can install package with PHP 8.2?

Workflow model

I don't see any doc about workflow in the API reference... ๐Ÿค”

Vcs->branch() needs to be nullable

Hello @jmleroux ,

I think I found a few more issues here, mainly looking at Vcs model, and branch is not nullable, but it is possible for it be null, mainly when you trigger a new tagged release, in that case "vcs" contains "tag" key instead of a "branch" key, so is it possible to make branch() in Vcs nullable?

Error on job creation

Uncaught PHP Exception TypeError: "DateTime::__construct() expects parameter 1 to be string, null given" at /home/grena/Workspace/nightly/vendor/jmleroux/circleci-php-client/src/Model/Job.php line 76

Model interface

Model interface:

  • createFromJson or create FromString ?
  • hydrate
  • toJson

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.