jmcleodfoss / pstreader Goto Github PK

In the Node display, right-clicking on leaf nodes of type "Attachment" (not "Attachment Table") pops up a menu with the single item "Save..." on it, but selecting save throws a NullPointerException. (This was discovered by Xanitizer.)

Exception encountered when outputting the Keyword-list element:

         <Keywords-list>
            <Keywords>Red Category</Keywords>
java.lang.NullPointerException
	at io.github.jmcleodfoss.util.XMLOutput.safeUTF8String(XMLOutput.java:141)
	at io.github.jmcleodfoss.xml.PSTToXML.addPropertyToNode(PSTToXML.java:172)
	at io.github.jmcleodfoss.xml.PSTToXML.addPropertiesToNode(PSTToXML.java:149)
	at io.github.jmcleodfoss.xml.PSTToXML.addFolderContents(PSTToXML.java:105)
	at io.github.jmcleodfoss.xml.PSTToXML.addFolderContents(PSTToXML.java:116)
	at io.github.jmcleodfoss.xml.PSTToXML.createXML(PSTToXML.java:224)
	at io.github.jmcleodfoss.xml.PSTToXML.main(PSTToXML.java:253)

This works fine when there is only one element:

         <Keywords-list>  
            <Keywords>Red Category</Keywords>  
         </Keywords-list>  

The Folders > Message > PC view for this keyword shows:

The corresponding data block is:

Note that the single keyword output before the exception is thrown is the second one in the data block.

In the PST Explorer application, if an entry in the Contact folder is a Distribution List, the members of the list should be displayed in a separate pane beside the Message pane. This does not work.

The right-hand side of the Node and Block displays should be cleared when the current file is closed or when a new file is open. Currently, the show the last-selected item.

In the Folder view, right-clicking on an attachment, or on the folder tree while an attachment is selected, should present a pop-up menu with the option to save the attachment. Similarly for saving the HTML message body (if present).

I have a limited knowledge of building this, so I might be missing something, but I got a build failure when running "mvn package" (see attachment for logs).

Environment:
OS
macOS 10.14.6

JAVA
java version "13.0.1" 2019-10-15
Java(TM) SE Runtime Environment (build 13.0.1+9)
Java HotSpot(TM) 64-Bit Server VM (build 13.0.1+9, mixed mode, sharing)

MVN
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /opt/apache-maven-3.6.3
Java version: 13.0.1, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-13.0.1.jdk/Contents/Home
Default locale: en_CA, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"

mvn_err.txt

Since cellExistenceBitmapIndex is stored as a byte, it is interpreted as negative it is higher than 127, which throws an ArrayIndexOutOfBounds exception as shown in the attached stack trace.
stack.txt