jmccann / chef-drone Goto Github PK

View Code? Open in Web Editor NEW

23.0 23.0 13.0 196 KB

Chef cookbook for Drone

License: Apache License 2.0

Ruby 99.43% HTML 0.57%

chef cookbooks drone-server

chef-drone's People

Contributors

Stargazers

Watchers

Forkers

xpepper paulczar rosstimson johnbellone shawnzhu mohitsethi predominant pombredanne epcim apealive-cookbooks atheiman jjasghar ragnarson

chef-drone's Issues

Remove dependency on unused cookbooks

I think, chef-vault, nginx and ssl_certificate can be safely removed. What do you think @jmccann?

build failure on ruby 1.9.3

here's the build failure: https://travis-ci.org/justincampbell/chef-drone/jobs/55595928

Gem::InstallError: ohai requires Ruby version >= 2.0.0.
An error occurred while installing ohai (8.1.1), and Bundler cannot continue.
Make sure that gem install ohai -v '8.1.1' succeeds before bundling.
The command "eval bundle install --without integration" failed. Retrying, 2 of 3.

the proper fix should be using chef 11 which depends on ohai 0.7.4

but the real question is, do we still need to support ruby 1.9.x?

Drone has a docker container that is built @ https://hub.docker.com/r/drone/drone/. The Drone instructions state to "install" drone by downloading and running the drone container (http://readme.drone.io/setup/overview/).

I was just curious if there were any pros/cons to installing via package instead of using the container, as this cookbook does, and/or thoughts of allowing it to be deployed via either method.

Thanks!

nginx SSL reverse proxy

I created a branch ( nginx-proxy ) with a recipe for installing a reverse proxy in front of drone. check it out and tell me what you think.

General admin (License and Changelog)

There should really be a license and a changelog for this cookbook for those pulling it from the Supermarket.

I'm have no preference at all what license you wish to use just as long as there is one, although the standard for Chef cookbooks seems to generally be Apache V2.

For the changelog I normally stick to the following format as it is mandated by the Stove gem which I use for releasing all of my cookbooks:

my_app Cookbook CHANGELOG
=======================

v1.1.0 (2014-05-10)
-------------------

* Some bug fixes
* A new feature


v1.0.0 (2014-02-02)
-------------------

* Initial release

I know you use Emeril to release this cookbook but Stove seems more actively maintained so it would make sense to use this format in case you wish to swap in the future.

Test Kitchen fails to converge on Ubuntu 12.10

When trying to run the Test Kitchen tests on Ubuntu 12.10 image it fails to converge as the Docker recipe detects that the kernel is too old. Weird thing is that Ubuntu 12.04 seems to work. If others confirm this you may want to consider removing support for these older versions of Ubuntu.

================================================================================       
Recipe Compile Error in /tmp/kitchen/cookbooks/drone/recipes/default.rb       
================================================================================       


DockerCookbook::Exceptions::InvalidKernelVersion       
------------------------------------------------       
Due to a bug in LXC, Docker works best on the 3.8 Linux kernel. You are currently running 3.5.0-17-generic.       
It is recommended that you upgrade your kernel to at least 3.8.       

More Info: http://docs.docker.io/installation/ubuntulinux/       



Cookbook Trace:       
---------------       
  /tmp/kitchen/cookbooks/docker/libraries/helpers.rb:26:in `alert_on_error'       
         /tmp/kitchen/cookbooks/docker/recipes/dep_check.rb:39:in `from_file'
         /tmp/kitchen/cookbooks/docker/recipes/default.rb:1:in `from_file'
         /tmp/kitchen/cookbooks/drone/recipes/default.rb:1:in `from_file'


       Relevant File Content:

       ----------------------

       /tmp/kitchen/cookbooks/docker/libraries/helpers.rb:

        19:      case action
        20:      when :warn
        21:        Chef::Log.warn <<-MSG
        22:  WARNING: #{exception}
        23:  #{msg}
        24:        MSG
        25:      when :fatal
        26>>       fail exception, msg
        27:      end
        28:    end
        29:  
        30:    # Helpers::Docker module
        31:    module Docker
        32:      # Exception to signify that the Docker daemon is not yet ready to handle
        33:      # docker commands.
        34:      class DockerNotReady < StandardError
        35:        def initialize(timeout)




Running handlers:       
       [2014-07-12T20:10:08+00:00] ERROR: Running exception handlers

       Running handlers complete


[2014-07-12T20:10:08+00:00] ERROR: Exception handlers complete       
[2014-07-12T20:10:08+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out       
Chef Client failed. 0 resources updated in 2.952250553 seconds       
[2014-07-12T20:10:08+00:00] ERROR: Due to a bug in LXC, Docker works best on the 3.8 Linux kernel. You are currently running 3.5.0-17-generic.       
It is recommended that you upgrade your kernel to at least 3.8.       

More Info: http://docs.docker.io/installation/ubuntulinux/       

[2014-07-12T20:10:08+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)       
>>>>>> Converge failed on instance <default-ubuntu-1210>.
>>>>>> Please see .kitchen/logs/default-ubuntu-1210.log for more details
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: SSH exited (1) for command: [sudo -E chef-solo --config /tmp/kitchen/solo.rb --json-attributes /tmp/kitchen/dna.json  --log_level info]
>>>>>> ----------------------