jlucaspains / go-rest-template Goto Github PK

Feedback from gmhafiz on reddit:

• You use both github.com/golang-jwt/jwt and github.com/lestrrat-go/jwx. it doesn't look like you are using golang-jwt/jwt for much.
• util package name is non-descriptive and does not tell me what it does. I'm going to link what I said not long ago https://www.reddit.com/r/golang/comments/134dwga/yet_another_realworld_implementation_go_kit/jihv0qg/ and https://go.dev/doc/effective_go#package-names
• Related to above, you did a if strings.Contains(err.Error(), "UNIQUE constraint failed") which is strange. It looks like it's specific only to modernc library. What will happen when a user tests against a different database?
• why not latest postgres version 15 in docker-compose file instead of 13
• try to use context from the request. For example

 res, err := opaQuery.Eval(c.Request.Context(), rego.EvalInput(input))
 // instead of 
 res, err := opaQuery.Eval(context.TODO(), rego.EvalInput(input))

• For testing, consider table-driven tests so that you can test multiple scenarios/use cases against a function. https://dave.cheney.net/2019/05/07/prefer-table-driven-tests
• to take advantage of docker caching, copy both go.mod and go.sum first, then run go mod download. Afterwards, copy the rest of the file. You'll get faster build thanks to caching. This is observable when you make a change in codebase and rebuild your image.
• Also consider running your app as non-root in Dockerfile.
• personal preference since you already statically-compile the app, you can use scratch or distroless image which is even smaller. Also, I try to avoid anything with alpine image https://martinheinz.dev/blog/92
• In readme, you can run docker compose up -d as daemon mode.
• A nitpick but your persistent volume claim file name for database is pvp.yaml. I assume it'd be pvc.yaml