Git Product home page Git Product logo

Comments (6)

perimosocordiae avatar perimosocordiae commented on July 24, 2024

Most of the lighting seems to work right, but there are weirdnesses for (some) blocks diagonally-adjacent to the sky:
Screen Shot 2012-12-24 at 1 21 10 PM

from minicraft.

jleahey avatar jleahey commented on July 24, 2024

This is because of the visibility matrix generated by the the world generator. This used to be a feature and it made the ground look nicer, but it's not worth it to have light travel diagonally. Soon visibility needs to be completely removed for lighting, and will require some tweaking.

from minicraft.

perimosocordiae avatar perimosocordiae commented on July 24, 2024

Cool, I'll just leave the lighting to you, then. 😁

from minicraft.

perimosocordiae avatar perimosocordiae commented on July 24, 2024

Recent commits look really good! One last (I hope) small bug:
Screen Shot 2012-12-27 at 8 09 14 PM

It's dark outside (just past midnight) but the non-air tiles are still tinted as in midday. This may be as simple as adding a check to timeOfDay in the code that gets the sun sources, but I'll leave this to you.

from minicraft.

jleahey avatar jleahey commented on July 24, 2024

Will do! This will be a simple fix. Also changeTile needs to activate lighting changes as well. Sand falling currently does not update lighting.

from minicraft.

jleahey avatar jleahey commented on July 24, 2024

Except that there are no torches, the tile tinting and lighting engine work.

from minicraft.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.