jlaamanen / signally Goto Github PK

Scenario:

• a logging library uses signally for updating the log level
• package x uses the logging library above
• package x also uses signally for updating some configurations
• if package x and the logging library both use events with the same name, unwanted effects may appear

Possible fix:

• make events always caller specific: find out the caller module ID (module root of the caller?) and create a new directory for it under .buffer

When started in Docker, events sent with CLI fail in parsing from JSON:

Error when handling event 1: SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at Object.readJsonFile (/app/node_modules/signally/dist/utils.js:26:17)
    at FSWatcher.<anonymous> (/app/node_modules/signally/dist/listener.js:28:34)
    at emitTwo (events.js:126:13)
    at FSWatcher.emit (events.js:214:7)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1364:12)

Manually entering events to .signally inside the container is working fine:

echo '{"event": "hello", "messages": ["Hei"]}' > .signally/1

CLI should indicate when an event is not listened to by the target process. This could be implemented e.g. by creating a directory for each listened-to event name under .buffer. Instead of a verbose object, each file would only include the messages as a JSON array.

If an event is not listened to (i.e. directory .buffer/[event name] does not exist), there should be an error, e.g.:

Event [event name] is not listened to

Add unit tests

After implementing unit tests #1, add automatic test running with Travis CI.