jitendra-1217 / razorpay-go Goto Github PK

It's more of a question than issue. While mockAPIBackend := NewMockBackend(ctrl) solves the problem of returning mock response. But in this solution, consumer of client should know which api is getting called to mock the api.

Though interface pollution is considered bad but isn't it better way to mock client in this case.

we should be reusing default clients instantiated in here

Lines in

can be changed to reuse if already instantiated earlier

var defaultRazorpayClient *razorpay.Client

func GetDefaultClient() *Client {
        if defaultRazorpayClient != nil {
                return defaultRazorpayClient
        }
        
        defaultRazorpayClient = NewClient(APIKey, APISecret, DefaultAPIBackend)
	return defaultRazorpayClient
}

Second Suggestion:
exposing a method to reuse razorpay client across all entities might be a good idea

func NewClient(razorpayClient *razorpay.Client) *Client {
	return &Client{razorpayClient}
}