Git Product home page Git Product logo

teamcolors's People

Contributors

attebury avatar briankennedy1 avatar catcolor1 avatar jimniels avatar mbm1607 avatar qwz avatar rottina avatar scottarnold avatar sixerswat avatar suburbsomeone avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

teamcolors's Issues

Update Minnesota Vikings Logo

Good catch from @mattq (comment on issue #14)

Looks like there is indeed a new logo, though the changes are rather subtle.

Currently, we are using this:
Old vikings logo

It appears this is the new one. Does that sound right?
Current vikings logo

I can't find an SVG version of the newest one. You happen to know the location of one @mattq ? If not, we'll probably have to do a PNG fallback for the Vikings.

print problem

Clever page but some or most of the hex values print as white on white (from Chrome) ... oops. Love to stay and play but don't time right this second. I'll check back later.

Brazilian Series A and B

Is there any interest in adding brazilian soccer teams? Specifically from 1st and 2nd divisions?

If you think that's relevant I would like to contribute with this.

Source for EPL, MLB, MLS, NHL?

For leagues/teams with no official colors, is there a source for the approximations?

I came across this link: http://www.glidden.com/Team-Colors and was wondering if those values would be 'better' than the current values.

Score the official paint colors of your favorite sports teams. Team Colors paints are perfect matches to college and professional sports teams’ colors, and are available from Glidden® paint at The Home Depot®.

Looks like the RGB values can be extracted from the individual swatches. I'd be interested in helping out on this if there is interest.

NBA Hex

NBA data set does not have HEX. For consistency I think it should have that. Thanks!

Create "click to copy"

To make copy/pasting of team colors easier, write a little javascript that implements a "clip to copy" functionality on the HEX values.

Potential pull request

I've forked your project and am using a few grunt plugins to create PNG fallbacks and am experimenting with the creation of league webfonts. It's still a work in progress, but I'm getting close to decision points and your input would help.

Is this something you'd be interested in merging back into this project or should I just plan to keep those changes in a separate fork?

If you'd prefer to keep it separate, I have minified the SVGs and can contribute those back if helpful
tc-nfl-med-sprite
.

EPL out of date

Using http://www.espnfc.us/english-premier-league/23/table as reference against your data file, it seems that you are a wee bit out of date (last years teams maybe?)

need to remove

  • Aston Villa
  • Newcastle United
  • Queens Park Rangers

need to add

  • Watford
  • Middlesbrough
  • Bournemouth

Once I source some colours, I'll let you know.

:rocket: Modernize Codebase

Hi @jimniels,

I want to work on upgrading the repo all over. For this I want to do the following changes:

  • ⬆️ Upgrade to React 18 and Functional Components
  • 🦺 Add TypeScript
  • 🏗️ Swap out CRA for Vite
  • 📦 Switch to use PNPM instead of yarn
  • 🎨 Improve Site Theming
  • 🧛 Add Dark Mode
  • 🔨 Complete the To-Do list

I am creating this issue to indicate that I am interested in working on this. Please let me know if this is something that you would consider merging and if you have any concerns or questions.

I think this is a cool project and should be kept up to date.

Screen Flickers on initial load

There is a small flicker that occurs on the initial page load. This is occurring because the stylesheet is being loaded by main.js and it has to wait for the document to be ready to edit.

Moving the loading into the template itself would correct this issue.

Washington Redskins is now Washington Commanders

The Washington Redskins changed their name and logo in 2020. Currently they are the Washington Commanders and the logo is a W. I believe the burgundy is slightly different but the yellow is the same.

Atlanta United and Minnesota United FC

Are joining the MLS in 2017. Here is the data I'm using but I dont have "official" colours (extracted with Tineye) and no logos:

{
  "name": "Minnesota United FC",
  "type": "MLS",
  "internalId": "MIN",
  "colours": ["#e2e3df", "#222", "#9bcce3"]
},
{
  "name": "Atlanta United FC",
  "type": "MLS",
  "internalId": "ATL",
  "colours": ["#252021", "#918254", "#7e000b"]
}

Pick the bones as you wish or ignore for now.

Use of SVG logos

Hi @jimniels - first of all, what a great wee project this is. Thank you for sharing it.

I am working on my own wee single page app / project to teach myself better React. Its on a similar theme to yourself. I came across your repo as I was trying to find logos of the teams and you have a great collection (and well sourced).

I was wondering if I would be able to use them in my personal (hopefully one day, commercial) project? More than happy to credit you appropriately (I did look for a License but I couldn't see one, sorry).

Thank you Sir and keep up the good work.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.