jhdezj / mc-project2 Goto Github PK

• Recommendation to use labels to identify each input ("Id") elements instead of h tags. (hint: )
• Best practice: Pay attention to HTML and CSS syntax rules. no space required between attribute name and value: (e.g. <link rel = "stylesheet" type = "text/css" ....). Similar thing in the CSS file (e.g.: .loginform :first-child{ ...)
• Best practice: Use indentation for code cleanliness.
• Element positioning: Consider the idea to add some more wrappers to make easier the form positioning.
• Congrats on using float. Unless required specifically in the project, We recommend to consider grid or flex, to avoid issues in element positioning.
• Tool for CSS layout visibility: checkout pesticide.io. It will help to avoid manually making boxes visible.

1.- We like the html and css structure and the presentation. The visual appearance of the page looks good.
2.- Best practice suggestions: A git-ignore is recommended. An assets folder for the images, fonts and css, etc. is also recommended.
3.- On line 7 and 129 in the css files: use hyphens instead of underscores or double hyphens.
4.- Check out the "span" element in blue and use "a" tags instead. This wherever the original has links.
5.- Check line 30 on the html, there's a big space.
6.- Best practices: use labels instead of the "h" tags.