jgowdy / corifier Goto Github PK

There are a few places where we need to compare version numbers, including .NET Framework version and package version numbers. We need robust and rational version number comparisons.

Detect if the project appears to be under source control and if so, we can skip the backup folder since source control provides a revert path. Should we ensure that the project we are changing doesn't have unchecked in changes?

Hi,

Goals
Milestone #1: Convert .NET Framework v4.6.1+ class libraries to .NET Standard 2.0 class libraries

Milestone #2: Convert .NET Framework v4.6.1+ console applications to .NET Core 2.0 console applications

are both implemented already?

The files we backup to CorifyBackup/ including CorifyBackup/AssemblyInfo.cs end up matching **/*.cs and thus are compiled in. We need to rename the files .bak or move them to a different folder outside the default glob.

We should blend the import of package.config with the existing .csproj references. Package.config may have a newer package version than is referenced in the .csproj, in which case we should use the newer version. Packages in package.config but aren't in the .csproj references might want to be left out?

We need to detect more of the cases we can't handle and reject the conversion in those cases. For example, legacy web references and service references might be a reason we can't proceed. Detecting certain packages which don't have .NET Core / .NET Standard equivalents like System.Web related packages, etc.

Currently we don't have any support for project references:

<ProjectReference Include="..\DispatcherSupport\DispatcherSupport.csproj">
  <Project>{83B8BD1A-5BD0-41FD-8538-7C76CCC7AC83}</Project>
  <Name>DispatcherSupport</Name>
</ProjectReference>
<ProjectReference Include="..\Reflection\Reflection.csproj">
  <Project>{65ae554e-0baa-4d39-a9c5-3d4f08b6343e}</Project>
  <Name>Reflection</Name>
</ProjectReference>

Should become:

The default glob of newer csproj files is **/*.cs which doesn't work for source files that aren't in that path. When we import .NET Framework projects, we should detect files not in that path and explicitly name them in the new csproj.