jgltechnologies / gin-rate-limit Goto Github PK

In the provided errorHandler example, should you not call abort (or something akin) on the Gin context? With the c.Abort() missing, the requests are always fulfilled, even after hitting the ratelimit.

e.g.

func errorHandler(c *gin.Context, info ratelimit.Info) {
	c.String(429, "Too many requests. Try again in "+time.Until(info.ResetTime).String())
	c.Abort()
}

Hi, i just noticed that you don't support setting the reset time when using the InMemoryStore or the RedisStore. I think it can be so much helpful and much easier than using the custom stores in order to just set the reset time.
I opened a pull request and added the support for setting rate limit for both InMemory and Redis store and also updated the Readme for it.
I'll be glad if it is any help to you, and also let me know if it needs any changes or fixes.