jfmengels / blog Goto Github PK

I just read https://jfmengels.net/disable-comments/. I have a couple of comments. As your blog doesn't have a comment section I decided to open an issue here. Feel free to close it if you want.

As far as I know, there is no static analysis tool out there that has disable comments and allows making some rules not disableable (please let me know if you know one!).

Rust has #![forbid(lint_name)] which can't be downgraded from a hard error to a warning or even completely silenced.

Forbid constructs that lead to false results

While I agree with the intention of this, it would make adding new lints a breaking change. For example in Rust many lints are part of the compiler and thus checked during compilation. The Cargo build system forcefully disables all lints of dependencies even when using #![forbid(lint_name)] to ensure that adding a new lint to the compiler can never break compilation of a dependency even if it forbids all lints. For dependencies you would have to make a PR, wait for the maintainer to accept the change and then wait for a new version to be published. For your own code however you can easily change it to fix the lint, so a new lint breaking your build is less of a problem.