jetwitaussi / pht Goto Github PK

[issue happened with php version 7.0.16]

It seems that $teams is a reference to $this->xml->getElementsByTagName('Teams'), so when a team is removed from $this->xml->getElementsByTagName('Teams'), it gets removed from $teams as well. As a result, the third team won't get checked/removed.
As a follow up error (probably one of many?), the flags are not correct, since those of both remaining teams are combined.

As a workaround, I changed the loops to

for ($t = $teams->length - 1; $t >= 0; $t--) {
 ...
}

which seems to do the trick.

Also, the condition has to be changed to
if ($this->xml->getElementsByTagName('Team')->length >= 2)

Add a composer.json file in order to be able to install the library via composer

Hello,
How can i get CONSUMER_KEY & CONSUMER_SECRET?
I have this massage on site:
You accepted the CHPP Developer Licence Agreement 2020-02-05 01:30:00

Thanks!

I'm using v2.21, git hash c20774e.

The problem I get is that if I try to get a user's second and third teams, the user ID is not set in the HTTeam object returned by PHT. This is simple to reproduce - just call $team = $ht->getSecondaryTeam(1234567, 0) (second team) or $team = $ht->getSecondaryTeam(1234567, 1) (third team), where 1234567 is replaced by a userid with two or three teams, and look at $team->getUserId(). The returned value is set to NULL. Primary teams, i.e. with $ht->getPrimaryTeam(1234567), seem unaffected.

Under PHP7 environment, the PHT\Cache\Void and PHT\Log\Void are not valid class names.

Fatal error: Cannot use 'Void' as class name as it is reserved in PHT/Log/Void.php on line 16

What I would suggest here is that we rename the classes to something like VoidCache and VoidLogger, although we will introduce a naming inconsistency in the Cache and Log classes. Another suggestion would be to rename all of the classes, i.e. VoidLogger, FileLogger.