Whenever I run fisher u, my Z_DATA is reset and I lose all history.
Is this a bug? If not, is there a way to go around that without having to manually backup than restore before every fisher update?

If I delete a directory I expect it to be gone from z's list too. Perhaps the easy way of doing this would be to check if the directory exists before cding to it, and if it doesn't then trying the next best match.

Steps to reproduce:

1. mkdir random-folder-name
2. cd random-folder-name
3. cd ../
4. z random-folder-name to see if it works
5. rmdir random-folder-name
6. z random-folder-name

After running step 6, you'll see an error like

cd: The directory “/path/to/random-folder-name” does not exist

Because of & sign in one of the completion paths (i assume) z causes a cd command to throw some errors messing all the terminal.

kmiasko ~/.c/fish λ cd conf.d/
kmiasko ~/.c/f/conf.d λ cd ..
kmiasko ~/.c/fish λ fisher install z
Installing 1 plugin/s
OK Fetch z github.com/fisherman/z
Installing 1 dependency
OK Copy getopts
Done in 1s 725ms
kmiasko ~/.c/fish λ cd conf.d

complete: Completion [huge list of directories] contained a syntax error
Expected an argument, but found a '&'
complete: [huge list of directories]

kmiasko ~/.c/fish λ

Hi!

When trying to install your plugin, the omf version gets installed:

> fisher z
Installing 1 plugin/s
OK Copy z
Done in 100ms

> fisher help z
There's no manual for this plugin.
Try online: <github.com/oh-my-fish/plugin-z>

> fisher --version
fisherman version 2.11.0 ~/.config/fish/functions/fisher.fish

> cat .config/fish/fishfile
oh-my-fish/plugin-z

Steps to reproduce

1. mkdir ~/\(whatever\)
2. z ~/\(whatever\)

Expected result

It changes directory to ~/(whatever)

Actual result

'/home/donjar/(whatever)' did not match any results⏎

Versions

$ fish -v
fish, version 2.7.1
$ fisher -v
fisherman version 2.13.2

rupa/z provides the following feature which apparently is also implemented in fisherman/z but does not work for me:

Common: When multiple directories match all queries, and they all have a common prefix, z will cd to the shortest matching directory, without regard to priority.

Test scenario

> mkdir -p foo/bar/a
> mkdir -p foo/bar/b
> cd foo/
> cd bar
> cd a
> cd ../b
> z -l
4          /home/jnns/foo/bar/b
4          /home/jnns/foo/bar/a
4          /home/jnns/foo/bar
> z -e foo
/home/jnns/foo/bar

I expect the directory to be changed to foo but I'm taken to the most frecent entry instead – not the shortest match.

I just installed fisher and then fisherman/z but running z anything will always return

'anything' did not match any results

If I open a new tab, z is no longer defined. Am I missing some steps? I also tried running brew install z and reinstally everything thinking that it would be a dependency but that didn't fix anything.

Incidentally brew install z; omf install z brings up a _z: command not found message so that doesn't work either. :(

Currently z does a hard match using contains. This is highly limiting, because this means that any subfolders would be ignored as well.

With the new string builtin, fish now has native support for regex matching, this would definitely make z users feel more at home.

Also, document Z_EXCLUDE in the README.

error like following image if history contain Chinese words:

Several situations:

1. I remove line /Users/tangmonk/Dropbox (个人)|1|1479957811 in ~/.z works again
2. change Dropbox (个人) to Dropbox 个人 works, it same the brackets problems

Original z allows jumping into sub directory. From z man:
z foo bar cd to most frecent dir matching foo, then bar

Adding this feature would be useful.

Ubuntu 16.04 ; fish 2.6.0 ; tmux 2.2

I'm seeing this error message quite often. I see it when just changing directory... or every time I run z. I have tried fisher rm z --purge and installing again but I'm seeing same behavior. Any ideas what I can do differently?

======================
cd
[I] ~  cd ..
complete: Unknown option “-- --- -------------- ----- ---------- ---------------------------- ----”
~/.config/fish/functions/__z_complete.fish (line 3):
complete -c $Z_CMD -a $__z_marks -f
^
in function “__z_complete”
called on line 17 of file ~/.config/fish/functions/__z_add.fish

in function “__z_add”
called on line 35 of file ~/.config/fish/conf.d/z.fish

in function “__z_on_variable_pwd”
called on line 5 of file /usr/share/fish/functions/cd.fish
with parameter list “VARIABLE SET PWD”

in event handler: handler for variable “PWD”

   complete -- edit command specific tab-completions

Synopsis
complete ( -c | --command | -p | --path ) COMMAND
[( -c | --command | -p | --path ) COMMAND]...
[( -e | --erase )]
[( -s | --short-option ) SHORT_OPTION]...
[( -l | --long-option | -o | --old-option ) LONG_OPTION]...
[( -a | --arguments ) OPTION_ARGUMENTS]
[( -f | --no-files )]
[( -r | --require-parameter )]
[( -x | --exclusive )]
[( -w | --wraps ) WRAPPED_COMMAND]...
[( -n | --condition ) CONDITION]
[( -d | --description ) DESCRIPTION]
complete ( -C[STRING] | --do-complete[=STRING] )

complete: Type “help complete” for related documentation

complete: Unknown option “-- --- -------------- ----- ---------- ---------------------------- ----”
~/.config/fish/functions/__z_complete.fish (line 4):
complete -c $ZO_CMD -a $__z_marks -f
^
in function “__z_complete”
called on line 17 of file ~/.config/fish/functions/__z_add.fish

in function “__z_add”
called on line 35 of file ~/.config/fish/conf.d/z.fish

in function “__z_on_variable_pwd”
called on line 5 of file /usr/share/fish/functions/cd.fish
with parameter list “VARIABLE SET PWD”

in event handler: handler for variable “PWD”

   complete -- edit command specific tab-completions

Synopsis
complete ( -c | --command | -p | --path ) COMMAND
[( -c | --command | -p | --path ) COMMAND]...
[( -e | --erase )]
[( -s | --short-option ) SHORT_OPTION]...
[( -l | --long-option | -o | --old-option ) LONG_OPTION]...
[( -a | --arguments ) OPTION_ARGUMENTS]
[( -f | --no-files )]
[( -r | --require-parameter )]
[( -x | --exclusive )]
[( -w | --wraps ) WRAPPED_COMMAND]...
[( -n | --condition ) CONDITION]
[( -d | --description ) DESCRIPTION]
complete ( -C[STRING] | --do-complete[=STRING] )

complete: Type “help complete” for related documentation

Over time, the $Z_DATA file grows in size, and will contain folder directories that have once existed, but since then been renamed/deleted.

Proposal:
z --clean to delete all entries. The current z --clean would be remapped to z --purge.

Steps:

1. Open $Z_DATA
2. Parse the file line by line, and check if the directory exists (test -d dir -- see man test for more info).
3. Write existing directories to a new temp file.
4. Replace the current $Z_DATA file with the temp file.

Some elements of steps 3 and 4 are in this repo, I believe.

This task is relatively easy, and makes for a good first PR.

First, i pretty much never manually cd into a projects git directory. But, when i open a fresh shell prompt, and type

z myproject

is always brings me to

~/code/github.com/skift/myproject/.git

and it does this for other projects too that have a .git directory. whenever I do z project it brings me into project/.git

I don't see any configuration options that relate to this. I want z to completely ignore ever going into a .git folder, as well as it not try and remember those.

I have also edited ~/.z to remove any lines that reference .git but once i cd into a project again it is there in my .z file both the main project directory, and one with .git appended

I am using fish 2.3 + fisherman in cygwin on Windows 7. Recently I upgraded fisherman and z plugin, and encountered this error while starting fish shell every time. Please check.

~/.config/fish/functions/__z_complete.fish (line 1): cat $Z_DATA | sed -e "s/|.*//" -e "s/^.*\$/\"&\"/g" | tr '\n' ' '
                                                                   ^
in command substitution
        called on line 0 of file ~/.config/fish/functions/__z_complete.fish

in function “__z_complete”
        called on line 32 of file ~/.config/fish/conf.d/z.fish

from sourcing file ~/.config/fish/conf.d/z.fish
        called on line 207 of file /usr/share/fish/config.fish

from sourcing file /usr/share/fish/config.fish
        called during startup

In the examples and test cases I don't see any regular expressions used. Can they be used? How would I jump to a path ending with foo? (not matching /path/foobar but matching /path/foo and /path/foofoo)

Hey, the snippet link in the README is a 404. Just wanted to let you know.

curl -L git.io/snippet >> ~/.config/fish/config.fish

Here's the log:

$ fin z
fin SAYS Installing 1 plugin
         ✔  z                       https://github.com/fishery/z
fish: Unknown command 'debug'
~/.config/fish/conf.d/z.fish (line 18): debug "$Z_CMD $ZO_CMD"
                                        ^
from sourcing file ~/.config/fish/conf.d/z.fish
    called on line 576 of file ~/.config/fish/functions/fin.fish

in function '__fin_plugin_enable'
    called on line 360 of file ~/.config/fish/functions/fin.fish
    with parameter list '/Users/mbischoff/.config/fin/z'

in function '__fin_install'
    called on line 201 of file ~/.config/fish/functions/fin.fish
    with parameter list 'z'

in function 'fin'
    called on standard input
    with parameter list 'z'

fin SAYS Done in 1s 993ms

In the ~/.config/fish/config.fish:

set -U Z_CMD "j"

In the fish:

❯ echo $Z_CMD
j

❯ j foo
fish: Unknown command 'j'

What am I doing wrong? I think, it has changed since the fisher 2.0 upgrade.

Hi,

first of all thanks for z.

I am using latest z (updated through fisher) on Fish 3.0.0, and I have this in my config.fish:

# Use j instead of z to jump to directories
set -U Z_CMD "j"

Whenever I try to jump to a previously visited directory, hitting TAB does not complete the path. So, for instance:

~
❯ j pla█

If I hit Enter, I end up in a directory (which in this particular case is the directory I want, but it isn't always the case).

But if I hit TAB, I get nothing:

~
❯ j pla █

Is this intended?

During a chat on Gitter fish-shell/fish-shell , Kurtis Rader - one of the core contributors - suggested that the startup time of this plugin could be improved by modifying this line:

 set -l __z_marks (cat $Z_DATA | sed -e "s/|.*//" -e "s/^.*\$/\"&\"/g" | tr '\n' ' ')

Looking at your profile the most expensive item is the (cat $Z_DATA | sed -e "s/|.//" -e "s/^.$/"&"/g" | tr '\n' ' ') subcommand. You can speed that up by 1) removing the useless use of cat, and 2) switching the sed and tr to the string builtin.

❯ z /adsfasdfsadfsadf
cd: The directory '/adsfasdfsadfsadf' does not exist

❯ z -e /asdfasdfsadf
/asdfasdfsadf

I wouldn't expect anything to be printed for the second call. Also happens with --list.

I tested with https://github.com/rupa/z, it prints nothing for the z -e case.

For reference jorgebucaran/fisher#452
@jorgebucaran

> fisher add jethrokuan/z
fetching https://codeload.github.com/edc/bass/tar.gz/master
fetching https://codeload.github.com/jethrokuan/z/tar.gz/master
linking ~/.config/fish/functions/bass.fish
linking ~/.config/fish/functions/__z.fish
linking ~/.config/fish/functions/__z_add.fish
linking ~/.config/fish/functions/__z_clean.fish
linking ~/.config/fish/functions/__z_complete.fish
linking ~/.config/fish/conf.d/z.fish
added 1 package, updated 1 package in 0.69s
> z
awk: can't open file /Users/arkadyan/.config/fish/functions/z.awk
 source line number 1 source file /Users/arkadyan/.config/fish/functions/z.awk
 context is
	 >>>  <<< 

From rupa/z

 -x     remove the current directory from the datafile

Use Case: Let's say I've moved the directory from one place to another. It'll take some time for z to learn that the new directory is the path I want to go to, especially if the old path was very frequently used. Instead, if I have an option to nuke the current director from the datafile, it can go to the next best match.

Another use case.

Steps to reproduce:
create a directory with a name containing single apostrophe, eg.

mkdir "andy's dir"
cd "andy's dir"

Now every time you change directories (cd) there is a huge error message

complete Completion '...' contained a syntax error. Unexpected end of string, quotes are not balaned

I just updated to Fish 3.0.2 and am now having z print a blank line after changing directories:

/ ❯❯❯ z desktop

~/Desktop ❯❯❯

When it used to do

/ ❯❯❯ z desktop
~/Desktop ❯❯❯

This does not happen when I just type z:

~/D/P/Research ❯❯❯ z
~/D/P/Research ❯❯❯

Any ideas?

Since recent updates, now I get this message with uses z command.

string escape: Invalid escape style 'regex'

Still lands in the correct folder as before, but always showing that warning.

And this is very well related with the latest commit: 4909fea

Just updated to the latest commit. My ~/.z file is full of stuff.

cat .z | wc -l
     140

Howerver, z seems have started from scratch. z --list just shows the one directory I cd' to after updating, likwise for z dir. Has the z file moved?

EDIT: Looking at the last commit, maybe it's using a new format and the old file was not migrated?
EDIT 2: Entries in ~/.z appear consistent.

I just installed this plugin with fisher, and I get the following output:

$ z
No command 'argparse' found, did you mean:
 Command 'augparse' from package 'augeas-tools' (main)
argparse: command not found
~/.config/fish/functions/__z.fish (line 17): 
    argparse $options -- $argv
    ^
in function “__z”
	called on line 25 of file ~/.config/fish/conf.d/z.fish

in function “z”
	called on standard input

'' did not match any results⏎

Any idea? I'm running ubuntu latest.

I'm getting this kind of verbosing every time I change a directory:

'/Users/lardissone/.z.yz5sE7' -> '/Users/lardissone/.z'

Also when I use the z command (I assume it's because it's changing directories too)

Is this a setting I can disable on my config?

Hi Hello I am looking for open source projects to contribute graphical design, I have done several jobs for free in opensource projects, I would like to know if you are interested that I make a logo for this your project ?.

Greetings

Nuno Jesus

Thanks for this amazing tool/port to fish!

Could there be a way to replace "/home/username/" or "/Users/username" with "~" in the completions?

After run z command in sudo fish mode, the ~/.z file will change owner to root, and I got permission denied error when I back to normal mode.

awk: ~/.config/fish/functions/z.awk:34: fatal: cannot open file '~/.z\' for reading (Permission denied)

Seeing some weird slowdowns on macOS that seem to come down to this z integration.

I'm in macOS, changing into a directory where I've just downloaded an exorcism exercise in Rust, and cd is freezing in a weird way, so I check my process list and see:
awk -v path /Users/geoffrey/work/learning/exercism/rust/reverse-string -v now 1575526304 -F

I was suspicious that it was z since I'd only installed the fish z-equiv recently, and cd integration is important to z, but it didn't take long to find that this line is from z.

If I paste that line myself, I get:
awk -v path /Users/geoffrey/work/learning/exercism/rust/reverse-string -v now 1575526304 -F awk: invalid -v option

See title.
This is from fish debug 3.
fish: path_get_path( 'z' ) z l fish: path_get_path( 'z' ) fish: path_get_path( 'z' ) fish: path_get_path( 'x86' ) fish: Job is constructed fish: Unknown command 'x86' fish: Job is constructed fish: Job is constructed fish: path_get_path( 'x86' )

Some time the z are not working. I got the error fish: Unknown command 'z'

❯ fisher ls
* not_simple          fin             getopts         humanize_duration   pwd_is_home
  await           fishtape        git_util        last_job_id         rvm
  bd              fzf             gitignore       menu            spin
  docker-completion   get_file_age        host_info       pwd_info        z

❯ z
fish: Unknown command 'z'

❯ functions
., N_, abbr, alias, await, bd, cd, contains_seq, delete-or-exit, dirh, dirs, down-or-search, eval, export, fin, fish_config, fish_default_key_bindings,
fish_indent, fish_mode_prompt, fish_prompt, fish_right_prompt, fish_sigtrap_handler, fish_update_completions, fish_user_key_bindings, fish_vi_cursor,
fish_vi_key_bindings, fish_vi_mode, fisher, fishtape, funced, funcsave, get_file_age, getopts, git_ahead, git_branch_name, git_is_detached_head, git_is_dirty,
git_is_empty, git_is_repo, git_is_staged, git_is_stashed, git_is_touched, git_untracked_files, gitignore, grep, help, history, host_info, hostname,
humanize_duration, isatty, la, last_job_id, ll, ls, man, math, menu, mimedb, nextd, nextd-or-forward-word, node, npm, open, popd, prevd,
prevd-or-backward-word, prompt_pwd, psub, pushd, pwd_info, pwd_is_home, rvm, seq, setenv, sgrep, spin, trap, type, umask, up-or-search, vared,

This used to work, I suspect
5e8d0e2

❯ z --list fish
0.813723   /Users/joe/.config/fish/fisherman
3.2818     /Users/joe/.config/fish
3.79838    /Users/joe/src/github.com/externl/fish-symnav
5.8145     /Users/joe/.config/fisherman/fishtape
6.30195    /Users/joe/.config/fisherman/z
6.85625    /Users/joe/.config/fisherman/getopts
8.107      /Users/joe/.config/fisherman/fzy
8.2639     /Users/joe/.config/fisherman/await
8.2639     /Users/joe/.config/fisherman/fzf
8.2639     /Users/joe/.config/fisherman/pure
8.2813     /Users/joe/.config/fisherman/last_job_id
8.31455    /Users/joe/.config/fisherman/get
8.45215    /Users/joe/.config/fisherman/menu
8.4889     /Users/joe/.config/fisherman/spin
9.15145    /Users/joe/.config/fisherman/docker-completion

curl -L git.io/confd >> ~/.config/fish/config.fish

this command fails because git.io/confd is not found

$ curl -L git.io/confd
Not Found

Hello there,

This might not be a bug. I want to make sure I am understanding how z should behave correctly.

Problem

z <tab> doesn't sort by frequency.

Example

z phantom yields to ~/Workspace/phantomjs-node.

z phantom<tab> shows

/Users/amirraminfar/Desktop/phantom-docker  /Users/amirraminfar/Desktop/test_phantom      /Users/amirraminfar/Workspace/phantomjs-node/examples  /Users/amirraminfar/Workspace/phantomjs-node/src         
/Users/amirraminfar/Desktop/phantom_test    /Users/amirraminfar/Workspace/phantomjs-node  /Users/amirraminfar/Workspace/phantomjs-node/lib       /Users/amirraminfar/Workspace/phantomjs-node/src/__test__

As you can see, phantom-docker shows up first. Shouldn't phantomjs-node be the first on the list?

I update to the latest version. z doesn't work after I restart the fish terminal.

I got this error:
fish: Unknown command 'z'

if I run fisher u, then it works again.

After setting set -U Z_CMD "j", completion stops working.

It would be great if the z config files would be computer independent (I'm having problems moving fish from one computer to another automatically due to it)

I think it should be enough to use paths relative to the home directory ~/path instead of absolute paths /home/user/path

I think is related to awk.

Try:

z -l > file

file is empty and output is printed to stdout

Sometimes, jumps to certain directories become erroneous after extended periods of usage. Currently, the only way to fix it is by going to the "~/.z" file and removing every line referencing to the directory or running z --clean to wipe out Z_DATA which will result in loss of data for other directories.

Feature Request:

z [-c --clean] <directory_name>
eg.
z --c documents will remove all the entries in the .z file that matches 'documents'

Should be trivial but useful.

Store previous directory path in a variable, and allow undo with z -u

This should return nothing:

❯ z --list fisherman >/dev/null ^/dev/null
2          /Users/joe/.config/fish/fisherman
2          /Users/joe/.config/fish/fisherman/conf.d
2          /Users/joe/.config/fish/fisherman/functions
6          /Users/joe/.config/fisherman
44         /Users/joe/.config/fisherman/await
44         /Users/joe/.config/fisherman/docker-completion
44         /Users/joe/.config/fisherman/fzf
44         /Users/joe/.config/fisherman/fzy
44         /Users/joe/.config/fisherman/get
44         /Users/joe/.config/fisherman/getopts
48         /Users/joe/.config/fisherman/last_job_id
48         /Users/joe/.config/fisherman/menu
48         /Users/joe/.config/fisherman/spin
52         /Users/joe/.config/fisherman/pure
52         /Users/joe/.config/fisherman/z

This makes it impossible to do something like:

z --list fisherman | grep docker-completion

Works fine with echo.

❯ z -e fisherman | grep z
/Users/joe/.config/fisherman/z

Likewise it seems output of --list is sent to stderr.

❯ /usr/local/bin/fish -l -c 'z --list fisherman' > /dev/null
2          /Users/joe/.config/fish/fisherman
2          /Users/joe/.config/fish/fisherman/conf.d
2          /Users/joe/.config/fish/fisherman/functions
6          /Users/joe/.config/fisherman
44         /Users/joe/.config/fisherman/await
44         /Users/joe/.config/fisherman/docker-completion
44         /Users/joe/.config/fisherman/fzf
44         /Users/joe/.config/fisherman/fzy
44         /Users/joe/.config/fisherman/get
44         /Users/joe/.config/fisherman/getopts
48         /Users/joe/.config/fisherman/last_job_id
48         /Users/joe/.config/fisherman/menu
48         /Users/joe/.config/fisherman/spin
52         /Users/joe/.config/fisherman/pure
52         /Users/joe/.config/fisherman/z

❯ /usr/local/bin/fish -l -c 'z --list fisherman' ^ /dev/null

Afaict only common: should be sent to stderr