Infinite loop when failing to get event about go.geteventstore HOT 3 CLOSED

Hi Setyven,

This is by design and is described in the documentation for the Next() method.

// Next gets the next event on the stream.
//
// Next should be treated more like a cursor over the stream rather than an
// enumerator over a collection of results. Individual events are retrieved
// on each call to Next().
//
// The boolean returned is intended to provide a convenient mechanism to
// to enumerate and process events, it should not be considered an indication
// of the status of a call to Next(). To understand the outcomes of operations the
// stream's Err() field should be inspected. It is left to the user to determine
// under what conditions to exit the loop.

from go.geteventstore.

Hi Jet, thanks for responding.

I use it as you suggested, so in the part of my code that processes each event, I inspect the StreamReader.Err(). Correct me if I'm wrong, but what I found out was, failure to fetch an event will cause the stream reader to get stuck with that event, even though my event handler already decides to skip it. An example of that would be when an event is permanently deleted, then a HTTP call to event store would return 410, which is then translated to goes.ErrDeleted.
Now, when Next() encounters this, it would immediately fails after trying to retrieve the event via s.client.GetEvent(url) and would return true without incrementing/decrementing the counter. Here's the part of the code in streamreader.go that I suspect (line 125)

Thanks a lot for your help.

from go.geteventstore.

If the event has not successfully been loaded then the streamreader should not increment. If you want to move onto the next index you can increment the version on the reader and then continue to call next.

This behaviour allows the consumer to process the error and decide what to do next.

from go.geteventstore.