Git Product home page Git Product logo

Comments (7)

jetbasrawi avatar jetbasrawi commented on June 25, 2024

Hi Thanks for highlighting this I will do some testing on this and get back to you.

from go.geteventstore.

setyven avatar setyven commented on June 25, 2024

This is a known issue with Go, because when forking the internal dependencies would still refer to the upstream repository. I'm facing this issue as well, been trying out some workarounds and haven't had luck so far.
This is a workaround that I found, let me know if it works for you @cwinkler http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html

from go.geteventstore.

cwinkler avatar cwinkler commented on June 25, 2024

@setyven yeah this should work, thank you.

I love go but i hate it's package management...

from go.geteventstore.

jetbasrawi avatar jetbasrawi commented on June 25, 2024

Thanks all,

I will be having a look at this and other issues today.

from go.geteventstore.

jetbasrawi avatar jetbasrawi commented on June 25, 2024

@setyven & @cwinkler

Is it agreed that the issue is with Go package management and generally an issue with forking Go projects.

@cwinkler the reason I did not want to include satoris package as a dependency and rather copy it into the project was to make it easier for people to use the package as it requires no dependencies. Copying code into the project rather than including as a dependency has been recommended as an approach where possible by some in the go community and that is what I was trying to do here. Perhaps using internal is not the best approach. Open to discussion on how to deal with this matter.

from go.geteventstore.

cwinkler avatar cwinkler commented on June 25, 2024

Since the EventID isn't necessarily a UUID I find it a bit odd to provide it automatically if an empty string is passed to NewEvent(). In order to know what kind of IDs are pushed to EventStore the User should provide his own ID.

But that are just my 2 cents. I'm fine with it as it is, my only problem was go's weird package management. As this is sorted out I can start implementing projection management into the client.

from go.geteventstore.

jetbasrawi avatar jetbasrawi commented on June 25, 2024

from go.geteventstore.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.