Comments (8)
7sharp9
commented on May 28, 2024
@kevmal This looks familiar to that one you fixed in Enum a while back, can you remember what was causing it? A cast from object or something like that?
from falanx.
7sharp9
commented on May 28, 2024
Think Ive found it...
from falanx.
kevmal
commented on May 28, 2024
Seems like two issues here. First problem is that typeof<obj>.IsAssignableFrom(--provided type--) always returns false resulting in a downcast here:
falanx/Falanx.Machinery/QuotationToAst.fs
Lines 143 to 152 in eb83880
Second issue is with the referenced version of fantomas, this fails
Fantomas.CodeFormatter.FormatDocument("bleh.fsx", "let a = 1 :> obj",Fantomas.FormatConfig.FormatConfig.Default)with System.InvalidCastException: Unable to cast object of type 'Upcast' to type 'Downcast'..
Luckily it seems like testing with fantomas master this may be fixed.
from falanx.
7sharp9
commented on May 28, 2024
I dropped all the box operations and coercions to obj and it seems to work, not got to upgrading Fantomas yet...
from falanx.
7sharp9
commented on May 28, 2024
So we also need to fix | Coerce(e, t) with special consideration for ProvidedTypes.
from falanx.
7sharp9
commented on May 28, 2024
@kevmal So on a ProvidedType instance maybe Utils.isAssignableFrom could work
from falanx.
kevmal
commented on May 28, 2024
Seems like Utils.isAssignableFrom just reduces to the same call.
let isAssignableFrom (ty: Type) (otherTy: Type) =
eqTypes ty otherTy || (match otherTy.BaseType with null -> false | bt -> ty.IsAssignableFrom(bt))from falanx.
7sharp9
commented on May 28, 2024
Fixed by #73
from falanx.
Related Issues (20)
- Usage of external project resources HOT 4
- Single nested enum fails due to no support in fleece HOT 11
- A proto file with a normal field follows by a oneOf results in incorrect generated code
- Missing oneOf property assignment in a message with more than one oneOf
- Recursively nested types fail HOT 7
- Mutual recursion is not supported HOT 1
- Enum with duplicate value produced code with duplicates
- Field ordering test produces out of ordered assignments in json HOT 1
- Running falanx on a proto file with a map in it fails with error HOT 2
- A proto message with primitive field then a map throws a not implemented exception HOT 1
- In a proto message a map followed by a primitive causes an exception HOT 1
- Poor error message HOT 2
- Enum in class is not working: lead.proto.fs(251, 13): [FS0001] No overloads match for method 'OfJson'. HOT 1
- update froto HOT 2
- Is there a way to import well known types?
- Generation fails when an Enum is inside of a oneof block HOT 1
- Move to FsProjects HOT 4
- It failed to build when there's a "bytes" field in the "oneof" HOT 1
- Parse fail for Mapbox vector_tile.proto HOT 1
- Quick question: does this use https://github.com/grpc/grpc-dotnet under the hood? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from falanx.