Single nested enum fails due to no support in fleece about falanx HOT 11 CLOSED

Discussed this here: fsprojects/Fleece#65
Requires substantial effort so marking as nice addition for now.

from falanx.

After discussion with @gusty we think this is best done in Fleece.

from falanx.

@gusty Can you remember what needs to be done for this?

from falanx.

Yes, there's no built-in support in Fleece for enums.

We can add a default codec there, based either on numbers or names. We need to decide which, it sounds to me that names are best suited for human-readable json.

Otherwise, since enums can't contain static members, the only way to encode them externally is by using explicit combinators.

Let me know which way you would prefer to move forward, for Falanx.

from falanx.

@gusty I think the reasoning around json encoding is to be more human readable so lets just go for names for now although the proto definition of json encoding is this:

enum | string | "FOO_BAR" |
The name of the enum value as specified in proto is used. Parsers accept both enum names and integer values.

from falanx.

OK, let's add an overload for this.

from falanx.

This is done in Fleece. Once a new nuget is created we should be able to reference it and fix this.

from falanx.

BTW: I think this

Parsers accept both enum names and integer values.

is also doable in Fleece, the question is whether it makes sense, as it would work one way only.

from falanx.

Why closing this without merging #169 ?

from falanx.

Just for the sake of closing it? But the issue is real and the PR that would solve it is not merged.

from falanx.

I know, but in the OSS world you never know who's using what.

If you're not the maintainer and can't merge the PR that will effectively close this issue, you should leave it open.

By closing it this way you are giving the false information that the issue is resolved, when is not.

from falanx.