jermay / crypto-kitties Goto Github PK

Refactor the kitty rendering to use inline styles instead of styled components

• Keep getting the warning that 200+ custom classes are being generated

If the user rejects the breed transaction in Metamask the "Given them some privacy" button no longer functions properly

Fix all the ESLint errors

UI: Add the gen zero counter

• To the Factory for sure
• Maybe as part of the nav bar visible to all?

• BUG: Market page > the approval notice appears on every kitty
• Market approval should only be asked for when the user clicks on the "Buy" or "Sell" button.

• Add a guard to the /factory route so that only the owner account can load the page.
• Do not show the nav link to the Factory if the current user is not the owner

A global notification of the current request status would be good. There is currently some support for this in the various redux slices. This notification will be particularly important on the test net as block time times are much longer.

Implement breeding

Create the marketplace contract to manage buying/selling of kitties.

• Deploy contract to Matic
• Add Matic as supported network in the UI

https://docs.matic.network/docs/develop/truffle/

1. Select a sire offer
2. Select a matron
3. Click "Give them some privacy" button
4. Click "Reject" in Metamask
5. Click "Give them some privacy" button again... nothing happens.

• Display cooldown name in the cat box
• Display the cooldown timer in the cattributes section if the kitty is on cooldown
• Disable breeding for a kitty if they are on cooldown (should display an informative message to the user)

Add Redux for state management

The random kitty colors are rather horrible. The 99 colors should be refactored so they're quantized color gradients.

Implement the approval and operator approval methods of the ERC721 spec

Implement breeding cooldowns similar to the official mechanics here:
https://guide.cryptokitties.co/guide/cat-features/cooldown-speed

Because there is only 1 cat on market ... Can't breed or buy.

The following error occurs when changing the :

"Pattern Color": From "Pin Stripes" => anything,

Warning: Removing a style property during rerender (background) when a conflicting property is set (backgroundColor) can lead
 to styling bugs. To avoid this, don't mix shorthand and non-shorthand properties for the same value; instead, replace the
shorthand with separate values.
    in div (at CatPartComp.jsx:21)
    in CatPartComp (at CatPartComp.jsx:17)

"Eye Shape": from "Down", "Right", "Left" => anything

Warning: Removing a style property during rerender (borderTop) when a conflicting property is set (border) can lead to
styling bugs. To avoid this, don't mix shorthand and non-shorthand properties for the same value; instead, replace the
shorthand with separate values.

When multiple transactions are pending at the same time:

• Notifications get stacked and can't see them all
• The state for the current user becomes inconsistent...
  • I.e. if start 3 kitty sell offers at once: the "sell for" label will appear only on the first and 3rd one, and the middle one will now have the correct sell state... all of the kitties show up in the marketplace however for other users

• Define supported networks (i.e. "Ganache", Ropsten, etc)
• When an unsupported network is selected
  • Should not attempt to query the contracts
  • Should clear the app state
  • Should disable all functions (similar to when wallet is not connected)
  • Should inform the user the given network is not supported, list the supported networks, and ask the user to switch to a supported network in MetaMask

There is currently no way to remove the sire from the "dad kitty" if the user decides not to breed a kitty with the sire.

1.Click "Buy" button on a Sire Offer from the Marketplace (user redirected to Breed page)
2. There is no way to un-select the sire as "dad kitty"

Create the frontend UI for breeding.

Breeding Page

• Add link to navbar
• Display list of kitties (smaller then main list)
• Select 2 cats
• When 2 valid cats selected display a "Breed" button to initiate transaction to contract
• Show birth event notification
• Display the new kitty

Error messages should be displayed. Either somewhere globally, or in the individual components.

Use a random number to choose which parent each cattribute comes from

• 1 bit for each cattribute
• If 1 then Dad, if 0 then Mum
• Use bit operations and math to extract each cattribute
• Recombine back into a number

Provider not set or invalid when Metamask not installed

Transaction Status:
Provider not set or invalid

Console error:

TypeError: Cannot read property 'on' of undefined
    at walletSaga.js:236

index.js:1 wallet error:  Error: Provider not set or invalid
    at Object.InvalidProvider (errors.js:39)
    at RequestManager.push../node_modules/web3-core-requestmanager/lib/index.js.RequestManager.send (index.js:133)
    at sendRequest (index.js:609)
    at Eth.send [as getChainId] (index.js:636)
    at WalletService.getNetwork (walletService.js:4)

When the user locks their wallet the app should reset to it's initial state i.e:

• Clear data
• Remove feature nav links, etc

Add a test for createKittyGen0() that tests only the owner can create gen 0 kitties.

When browsing kitties in the list with next/prev, sometimes the cattributes are not reset between kitties resulting in artifacts from previous kitties.

Help.
when i breed/generate new cat sometimes gaves me this error

TypeError: Cannot read property 'color' of undefined
ColorCattribute.getCssColor
src/components/js/ColorCattribute.js:27
24 |
25 | // returns the hex color value
26 | getCssColor() {

27 | return colorObj[this.value].color;
| ^ 28 | }
29 |
30 | get valueName() {

Add a new permission for creating generation zero kitties

• Should support adding and removing addresses
• Should support multiple addresses

• Deploy contracts to test net
• Deploy dapp to Netlify

When a new gen 0 kitty is created the gen zero count is not updated for other users.

Sire and sell offers are mixed up in the breed page

• Sire offer list is coming up blank
• Any kitty with an offer is coming up as a sire offer when assigned as the dad kitty

• Connect the UI to the smart contract
• Implement the "Create Kitty" button

If the user selects a new network before pressing the "connect" button all the refresh code is executed without the user permission.

• Add a "Connect" button so the dapp only gets the wallet accounts when the user clicks the button
• The page should reload when the ethereum account changes

Create the front end marketplace UI

• Redeploy contracts
• Create service class for KittyMarketPlace
• Modify "My Kitties" list view with "Sell" button
• Add market page
  • Pagination
  • Another wrapper for CatBox with "Buy" button and price

I have 1 cat in one account and when I try to breed with siring cat I got this message

sender not kitty owner OR approved

transaction is
here

Implement the siring feature where a kitty can be offered for breeding in the marketplace so someone else can create a new kitty with them.

Contract

• Add a contract function to get all kitties owned by an address

Frontend

• Add router and routes for the Kitty Factory and Kitty List View
• Add navigation bar
• Create a kitty list view in the front end to display all of a user's kitties