Websockets about roda HOT 4 CLOSED

I've confirmed this is an issue with Rack::Lint. If I use the Rack::Lint middleware explicitly, I get that error. This is either a bug in Rack::Lint::HijackWrapper or a bug in faye-websocket for not handling Rack::Lint::HijackWrapper. Personally, I think it is a bug in the Rack::Lint. I would file a issue in rack, and if they say it's not a bug in rack, then file a issue in faye-websocket.

I don't think it is a bug in Roda, I think you would run into this in other frameworks that use faye-websocket and Rack::Lint together, unless the framework had a specific workaround for this bug. I try to avoid having framework workarounds for bugs in other libraries, as that makes it less likely for the underlying bug to get fixed.

I think the following is needed to get Rack::Lint::HijackWrapper to work with faye-websocket:

class Rack::Lint::HijackWrapper
  def to_int
    @io.to_i
  end
end

from roda.

From the error message, it looks like this is related to Rack::Lint. Can you try running without Rack::Lint and see if it works? Assuming it works without Rack::Lint, this probably a bug in Rack::Lint.

The Roda specs use thin and not puma, but I have tested the websocket support with puma and it does work (slightly older version, 2.12.1, but I doubt that matters).

from roda.

How do I do that? I didn't add it in, the only gems I installed myself were roda, clearwater, faye-websocket, and slim (and maybe one other, but nothing rack-related). So I assumed it was something in the Roda/Rack/Faye triad.

I actually went with Puma as a web server because it didn't work with thin, either, but I figured I was screwing something up. When it didn't work with puma, I figured it might be time to file an issue.

from roda.

Awesome, I really appreciate you taking the time to check it out. I wasn't using Rack::Lint explicitly, but maybe something was injecting it. My own experience in dealing directly with Rack is pretty limited and the hours I spent trying to figure this out were entirely fruitless, mostly because I didn't know what to look for. I'll go ahead and put in an issue on Rack.

from roda.