Asset dependencies are not respected in `render` plugin about roda HOT 7 CLOSED

OK, thank you. I was working on a spec first, so once I have a failing spec, I can hopefully merge the PR and test that it fixes the issue.

from roda.

I agree this is a bug. We probably need the same type of code that the assets plugin uses, where you can pass an array of dependencies and it checks the mtime for all of them. Maybe we can pass the :dependencies option for the asset in the render call in the assets plugin, and then in render plugin, in retrieve_template, after creating the TemplateMtimeWrapper, set the dependencies on the template if render_opts[:dependencies] is set. Then in TemplateMtimeWrapper#modifed?, have it check all dependencies as well as the path itself, similar to the code in the assets plugin.

from roda.

@jgarth Is this something you plan to work on in the near future? If not, I can work on it before the next release.

from roda.

Yes, I'd like to submit a PR over the weekend. However, if this is more urgent to you then by all means go ahead.

from roda.

That sounds great. The weekend should be fine. The next release isn't for a couple weeks.

from roda.

I plan to work on this shortly.

from roda.

I added a PR with what I currently have, but I failed to incept a proper spec for the changes to the asset plugin

from roda.