jeremybobbin / libst Goto Github PK

I'm enjoying experimenting with the libst library, thanks for doing this! It makes really good sense to have this as a library and I hope the st project takes it up.

This isn't an issue as much as some clean up suggestions. I can submit a pull request if you'd like, but I'm not sure if you'll agree with all of them.

Unused function declarations

These functions are declared in libst.h but aren't defined in libst.c. I also don't see them used in any of the examples, so it should be safe to just remove them.

void selclear(Term *);
void selinit(Term *);
void selstart(Term *, int, int, int);
void selextend(Term *, int, int, int, int);
int selected(Term *, int, int);
char *getsel(Term *);

Convenience typedef aliases

These typedef aliases of unsigned types are nice to have, but I don't think they belong in this library header file. They are not necessary to use the library and might be redefined in code that's trying to use the library, potentially causing conflict. I think it's better to move them into libst.c, and then copy them to the st.c example where they are also used.

typedef unsigned char uchar;
typedef unsigned int uint;
typedef unsigned long ulong;
typedef unsigned short ushort;

Convenience functions

These convenience functions are also nice to have, but again I don't think they should be offered as functions in this library's header file. die() in particular is a function that many programs define on their own, and having it in libst.h could cause a conflict. Similarly for the other three functions. I recommend moving the declarations into libst.c and then copying them into the st.c example where they are also used.

void die(const char *, ...);

void *xmalloc(size_t);
void *xrealloc(void *, size_t);
char *xstrdup(char *);