jerboa88 / dark-mode-for-outlook Goto Github PK

What feature would you like?
Originally reported by Bernard. Some business users have their mail server hosted on a custom domain. A configuration option should be added so that users can add additional URLs where the dark theme will be applied.

Users of Microsoft Exchange usually have a mail URL that ends in /OWA so this could potentially be hardcoded, but it's probably a better idea to just create a configuration item so that URL patterns can be more specific.

https://docs.microsoft.com/en-us/exchange/troubleshoot/client-connectivity/set-up-web-access

Description
Update dependencies to latest versions.

Describe the bug
The top portion of the child menu shown after clicking on 'Move to a different folder' is a dark gray as expected, but the bottom portion is a light gray and reacts on hover. This could be due to an element sizing issue, or because subfolders are shown with a different background color in the list.

Screenshots

Description
zip-local dep requires a version of jszip that is vulnerable to prototype pollution. Replace with a different library or patch zip-local.

Note that this doesn't pose any risk in our case because this library is only used in the build script. However, we should consider switching to a better maintained library regardless.

Describe the bug
The styling of this search bar should match other search bars on the page.

Screenshots

Helpful info

• Extension version: v3.3
• Outlook script version: 20201228001.01

Describe the bug
Navigation buttons (mail, calendar, people, etc.) at the bottom of the left sidebar appear to be missing on the O365 variant of Outlook after the v3.3 fix. Possibly a result of hiding the sidebar ad (which does not exist on O365).

Helpful info

• Browser & version: All
• Extension version: 3.6
• Outlook script version: 20230616004.08

Describe the bug
After the latest Outlook redesign, a white border is being shown under all messages.

Steps to reproduce
Steps to reproduce the behavior:

1. Go to any folder in Outlook

Expected behavior
Remove the white border or style it in a more visually appealing way.

Screenshots
If applicable, add screenshots to help explain your problem.

Other
Add any other context about the problem here.

Description
There is currently no build script for Windows, so this should be added.

Describe the bug
Various buttons throughout the OWA don't react to hovering, making it harder to see what is being clicked. Examples:

• Navigation bar buttons (Skype, Onenote, Settings, etc.)
• Message right-click child menu. The parent context menu has hover effects, but none of the submenus do
• Search suggestions
• Search folder picker
• Rich text formatting buttons when writing a message
• Date picker popup

Helpful info

• Browser & version: All
• Extension version: 3.6
• Outlook script version: 20230616004.08

Describe the bug
An ad is shown at the top of the message when in the Inbox.

Steps to reproduce
Steps to reproduce the behavior:

1. Disable third-party ad-blockers
2. Go to the Inbox

Expected behavior
All ads should be hidden.

Screenshots

Other
Add any other context about the problem here.

Helpful info

• Browser & version: All
• Extension version: 3.6
• Outlook script version: 20221209009.13

Describe the bug
An ad is shown at the top of the message when in the Inbox.

Steps to reproduce
Steps to reproduce the behavior:

1. Disable third-party ad-blockers
2. Go to the Inbox

Expected behavior
All ads should be hidden.

Screenshots

Description
See if it is worth upgrading to Chromium's Manifest V3 at this time and make all the necessary changes if so. Compatibility with other browsers must be considered.

Helpful info

• Extension version: v3.3
• Outlook script version: 20201228001.01

Describe the bug
Styles for the toasts shown when a message is moved/deleted are broken once again. When fixing, need to confirm that styles work with all possible reading pane positions.

Screenshots

Describe the bug
Originally reported by Derrick. When the built-in Outlook dark mode is not enabled (and sometimes it is completely disabled by admins on O365), some messages do not show up correctly on a dark background. There are currently styles to try to force message text to display as a lighter color, but this does not always work as there are an infinite amount of ways an email can be structured.

This is an issue both while writing and viewing emails.

Potential solutions:

1. Send PATCH request to https://consumer.suite.office.com/api/settings/usertheme with payload {"IsDarkmode":true}. In testing this endpoint seems to be blocked by CORS, so I'm unsure if forcing a request through would have any effect. Manually replaying the XHR does nothing either. Interestingly, this request is triggered when updating the themeData.IsDarkTheme property via React DevTools, although changing the property doesn't actually update the page.
2. Modify React properties that control dark mode and force an update. The relevant property is $r.props.themeData.IsDarkTheme. This could be challenging because it seems like Outlook exclusively uses props instead of state, and I'm not aware of a method of updating the props and triggering an update after the props are first defined. We may have to modify the relevant property before any React components are loaded if using this approach.
3. Send POST request to https://outlook.live.com/owa/0/service.svc?action=UpdateUserConfiguration&app=Mail&n=xx with payload: {"__type":"UpdateUserConfigurationJsonRequest:#Exchange","Header":{"__type":"JsonRequestHeaders:#Exchange","RequestServerVersion":"V2018_01_08","TimeZoneContext":{"__type":"TimeZoneContext:#Exchange","TimeZoneDefinition":{"__type":"TimeZoneDefinitionType:#Exchange","Id":"Mountain Standard Time"}}},"Body":{"__type":"UpdateUserConfigurationOwaRequest:#Exchange","UserConfiguration":{"__type":"ServiceUserConfiguration:#Exchange","UserConfigurationName":{"__type":"UserConfigurationNameType:#Exchange","BaseFolderId":{"__type":"DistinguishedFolderId:#Exchange","Id":"root"},"Name":"OWA.UserOptions"},"Dictionary":[{"__type":"UserConfigurationDictionaryEntry:#Exchange","DictionaryKey":{"__type":"UserConfigurationDictionaryObject:#Exchange","Type":"String","Value":["isDarkModeTheme"]},"DictionaryValue":{"__type":"UserConfigurationDictionaryObject:#Exchange","Type":"Boolean","Value":["true"]}}]}}}. This seems to be the endpoint that actually updates user configuration.
4. Inject a script that performs contrast-checking on each piece of text and adjusts the colors as appropriate. Apparently this is what Outlook does themselves to make emails readable when using the built-in dark mode, but it seems more difficult to deobfuscate the original code that does this instead of rewriting it from scratch. This may be the only way of fixing message styling since the methods above may not work with O365.

Helpful info

• Browser & version: All
• Extension version: 3.6
• Outlook script version: 20230616004.08

Describe the bug
An ad is shown at the bottom of the message list when the screen is narrow

Steps to reproduce
Steps to reproduce the behavior:

1. Disable third-party ad-blockers
2. Go to any folder in Outlook

Expected behavior
All ads should be hidden.

Screenshots

Other
Add any other context about the problem here.

What feature would you like?
On the advanced search pane, horizontal borders should be removed and input fields should be styled to match existing search boxes on the page (same border radius, background color, etc.).

Other

Description
The extension screenshots are out of date and don't show the current version of Outlook Web.

What feature would you like?
Existing styles for Outlook mobile were broken a while ago by an Outlook update. These need to be rewritten from scratch

Describe the bug
The styling of this search bar should match other search bars on the page.

Screenshots

Description
Publishing new releases is always a hassle because each store requires different deliverables. Update the build script so that these items can be generated automatically to speed up the process. Specifically:

Chromium

• Create full size webstore screenshots and generate smaller versions for Chromium webstore and others

Edge:

• A 300x300 extension icon (maybe generate a 256px icon and add it to the manifest instead?)

Firefox:

• Zipped source code (include entire project folder except node_modules and build)

Opera:

• An (optional) 300x188 promo image for Opera
• Store listing text (en and es) that does not contain any emojis

Helpful info

• Extension version: v3.3
• Outlook script version: 20210103002.04

Describe the bug
Ad blocking is broken as of sv20210103002.04.