jenslind / electron-gh-releases Goto Github PK

How can I upload 32 and 64 bits nupkg? Do I have to use an special name? Grunt electron installer creates the same nupkg name. I've tried uploading 64 bits version only but it breaks 32 bits app. How do I handle both versions?

It's cool repo.
I try it agein.But I don't known that auto_updater.json format.
Is there example?

Hello! When I'm trying to use updater.install() but it seems that updater is undefined. Here you can find the source code.

Details

• Electron 1.0.2
• electron-gh-releases 2.0.3 (Also tried 2.0.2)

Source Code

const updater = new GhReleases(autoUpdateOptions);

updater.on('error', (event, message) => {
  console.log('ERRORED.');
  console.log('Event: ' + JSON.stringify(event) + '. MESSAGE: ' + message);
});

updater.on('update-downloaded', (info) => {
  console.log('Update downloaded');
  confirmAutoUpdate(updater.install);
});

The Error

Uncaught Exception:
TypeError: Cannot read property 'autoUpdater' of undefined
    at install (/Applications/Gitify.app/Contents/Resources/app.asar/node_modules/electron-gh-releases/GhReleases.js:197:11)
    at Function.<anonymous> (/Applications/Gitify.app/Contents/Resources/app.asar/main.js:45:9)

Screenshots

The value of updater:

The error:

Update

It looks like it is actually updating the app but it still throws that error

https://github.com/atom/grunt-electron-installer#handling-squirrel-events

updater.on('win32-squirrel-install')
updater.on('win32-squirrel-uninstall')
updater.on('win32-squirrel-updated')

I get this error after an update is downloaded. I see the log of update downloaded but "update-downloaded" event is never fired. I've checked the folder where zip should be and it's empty but something is downloaded and removed before the crash.

The full error is:

Could not locate update bundle for {appname} within file:///Users/{me}/Library/Application%20Support/{appname}.ShipIt/update.nQcEUZ3/: (null) at Error (native)

Any idea on what could be wrong? I'm using electron-release and electron-packager to package and upload to github.

Instead of having access to auto_updater only in the callback when creating a new instance we should make sure it is returned instead.

So instead of how it works now, we should do something like this:

var update = new gh_releases(options)

// Electrons auto_updater instance
update.auto_updater

// Also, adding an downloaded event to gh_releases
update.on('downloaded', function (info, quitAndUpdate) {
  // Install the update
  quitAndUpdate()
})

Looks better 🐈

Electron-builder is suggesting to switch to NSIS for building, and as such they are adding auto updating to NSIS. Will this module be able to work with the new format?
(See electron-userland/electron-builder#529)

Should be doable whenever electrons auto updater supports Windows.

See electron/electron#1984

Hello.

New to developing Electron apps, so I'm not quite sure where the Usage Example would go - would it be in the electron app file, or my app's own index file?

Thanks.

How feasible would adding windows and linux support be?

I get this error after updating to electron 0.36.0.

This is the full error returned on _getLatestTag method:

{ [ReadError: unexpected end of file]
  code: 'Z_BUF_ERROR',
  message: 'unexpected end of file',
  host: 'github.com',
  hostname: 'github.com',
  method: 'HEAD',
  path: '/myapp/myapp-desktop/releases/latest' }

I updated electron trying to find if the issue with quitAndUpdate not working was fixed.

Facing the issue while updating the new version from github.

Uncaught Exception:
Error: Code signature at URL file:///~/Library/Caches/com.electron.sample.ShipIt/update.3QUAiQg/sample.app/ did not pass validation: code object is not signed at all
    at Error (native)

When you call check on the API it returns an exception if they aren't window/mac.

https://github.com/jenslind/electron-gh-releases/blob/master/src/GhReleases.js#L105-L106

Is it possible to to still check if an update is available, but have download do this check? That way I can alert the users "there IS an update, but you need to download it manually" instead of "you don't support updates, and I'm not sure if there is one" ?

Hello there, I've been using electron-gh-releases for some time now (auto-updated about 4 new versions with success) for Gitify.

So the procedure I follow every time is:

• Use electron-packager
• Code sign the app
• Compress the app

I'm about to release a new version of Gitify, reaching version 1.0.0 from 0.0.19 and I'm trying to test if the autoupdater works but it looks like it is not working. I've got a test repository with version 1.0.1 release(with a tag and auto_update.json).

In order to test it, I've also built version 1.0.0 but when it loads I'm getting the following error:

Error: The zipUrl (https://github.com/ekonstantinidis/gitify-test/releases/download/1.0.1/gitify-osx.zip) is a invalid release URL. Status: false

If you go to the zipUrl you will see that it is working fine. Any ideas on what could be wrong?

Ps. Thank you for the great work on the package!

electron-gh-releases needs to use autoUpdater.on('error', cb) to catch update errors.

Can we auto update from private repos?

Thanks

would it be possible to implement an option to [attempt] to autodetect the download based on the file name? for example, it could look for "osx" in the file name

Hi, I am not too sure if I'm doing anything wrong but this is the error I get when executing updater.check()

Any idea?

Is there a reason you are not publishing the compiled files (ES5 support)?

Even being possible include this package in my babel configuration like this example below. I usually have seen people providing the compiled version.

"ignore": "/node_modules\/(?!electron-gh-releases)/"