This email foo@foo,com is valid, but it should be. Because the email contain a comma.

Great plugin by the way!

I have a checkbox and a hidden field set to either true or false.

The checkbox should only be validated against if the hidden field is set to 'true'. I am using requireIf, but this doesn't appear to be working. The form passes the validation whether it's checked or not.

Rules:

  const validator = new window.Validatinator({
    'my-form': {
      'terms': 'requiredIf:payment_required:true'
    }
  });

HTML:

<form name="my-form">
  <input name="payment_required" type="hidden" value="true">
  <input name="terms" type="checkbox" value="mycheckbox" id="terms">
</form>

Is this a known issue? I cannot find much information on validating checkboxes against another field.

Thanks.

UPDATE:

I think this related to changing the 'payment_required' field's value dynamically with JavaScript. It doesn't seem to get picked up from a value that's changed this way.

ES6 support was added with the introduction of browserify with the babelify transform. Let's make use of babel!

• Less Var - More Let
• Classes > Prototypes
• Arrow Function > function() {} [In most cases]
• ....

When you have a field with a name of 'name' ( )

This causes an error: "Couldn't find the field element ... for the form ..."

Hey,

Im using validatinator on one of my projects. Anyway, I've run into an issue, that if your input name attribute colide with e.g. meta tag, the validatinator gets broken, because it checks in getFieldsValue() method whether the input name exists, but not within the form, but inside document.

So if you have <meta name="author" value="xx" /> and inside a document you have <input name="author" ...> the method fails.

The method should check whether it is really inside the form, not in document.

This issue effects:

• same
• difference
• requiredIf
• requiredIfNot

In all of these methods the otherField parameter is expected to be an HTMLInputElement. However, when the validation method is prepared from a string via the config, this parameter is a string. For example:

{
  ".my-form": {
    ".my-field-selector": "required|same:.other-field-selector",
   }
}

/* is parsed to */
[
   ["required"],
   ["same", ".other-field-selector"]
]

/* Then the validation is called like this */
HTMLFormValidations.same(form, field, ".other-field-selector")

/* Within the "same" method this becomes */
...
field.value == ".other-field-selector".value
...

/* This always evaluates to false since strings do not have a "value" property */

Similar issues are present in the other methods.

I'm happy to provide a PR which will address these issues.

(not an issue, merely a question) Is it possible to initiate the form validation based on data attributes?
eg:
<input type="text" name="my-fields-name-attribute" data-required="true">

Why Alpha and others validators

const ALPHA_REGEX = new RegExp(/^[a-zA-Z]+$/);
const ALPHA_DASH_REGEX = new RegExp(/^[a-zA-Z-_]+$/);
const ALPHA_NUMERIC_REGEX = new RegExp(/^[a-zA-Z0-9]+$/);

have "+" what means that they expect not only Alpha character but it "REQUIRE" at least one char. What means that they force people to put something there.

It should be write like that :

new RegExp(/^[a-zA-Z]*$/);

And if some one need alpha and required then he have to combine validators: 'required|alhpa'

6 years projects and still .....

The types declarations are missing from the dist directory in the npm release.
Not sure if something went wrong for the 2.0.4 release or if this is a more long standing problem but there is no ./dist/types directory included when installing from npm.

At first glance, having multiple forms with the same names (and the same fields and validation rules) appears to work...but after an initial validation run, it's impossible to correct / re-validate the form again - I assume because it's getting stuck on another form of the same name.

The reason I have multiple forms is that this website in particular repeats the same newsletter signup form throughout a very long page and it's placed there via multiple includes.

It would be very repetitive to have to maintain forms as being distinct, even if they're the same with just a different name simply because validation wont run on multiple forms of the same name.

Any ideas with this at all? It's a bit of a road blocker for me. As far as I know Validatinator only works with names.

Hey. It'd be really handy to be able to specify custom validation messages for different fields

var validator = new Validatinator({
    signUpForm: {
        name: 'required',
        email: 'required'
    }
}, {
    signUpForm: {
        name: {
            required: 'Please provide a name.'
        },
        email: {
            required: 'You really should have email.'
        }
    }
});

Thanks for the awesome work

Currently, checking if a field contains an email or a url automatically set it required. This is a bit annoying since the "required" validation check exists.

Add support for using browserify

While this library has lots of good validation options, some valid field values simply don't fit neatly into one of those validation options. It would be nice to have a way to pass a RegEx string as part of a field validation configuration.
For example:

{
   ".my-field-query-selector": "required|pattern:\\d{3}[\\*_\\-][a-z]{4}",
   ...
}

This example would create a regular expression for a field value that starts with 3 numbers has one of *, _ , - and is followed by 4 lowercase letters.

Then this could be parsed in a new pattern method:

static pattern(form: HTMLFormElement, field: HTMLInputElement, regexPattern: string) {
  const regex = new RegExp(regexPattern);  
  return regex.test(field.value);
}

The double backslash is required since it is in a string. A single backslash would only create an escape sequence inside the string and would not result in a literal backslash in the constructed regular expression.

Validatinator claims this email is invalid, yet it is a perfectly valid email: [email protected]

getFieldsValue will raise an exeption if e.g. a hidden field is named "name" and one field to be validated

this

163: if (fieldElement.form && fieldElement.form.name === form) {

will be false, because fieldElement.form.name will return the input "<input type=​"hidden" name=​"name" value>​"