Git Product home page Git Product logo

Comments (10)

tuukkamustonen avatar tuukkamustonen commented on June 21, 2024

Uh, too many expectations and I should actually read the error message before opening a ticket. Apparently this was caused by an invalid regex to file pattern...

from violation-comments-to-stash-plugin.

tuukkamustonen avatar tuukkamustonen commented on June 21, 2024

@tomasbjerre Although, it's a bit confusing that front page says:

image

while Flake8- and Pylint-formats are different and flake8 does not execute pylint internally.

If the tool really already supports pylint-output, I would suggest to change README as:

- Flake8 (Pep8, Mccabe, PyFlakes) / PyLint

And on configuration page, put:

FLAKE8 / PYLINT:    _______________________

...just to make it more evident?

from violation-comments-to-stash-plugin.

tomasbjerre avatar tomasbjerre commented on June 21, 2024

I can add a pylint parser if you have a sample pylint report? Command for generating it and its output.

from violation-comments-to-stash-plugin.

tuukkamustonen avatar tuukkamustonen commented on June 21, 2024

Alright, I added couple of gists (with pylint 1.6.4):

https://gist.github.com/tuukkamustonen/a9994bb4eededde6c3095eba922e73c3
https://gist.github.com/tuukkamustonen/78d38559176eea7cfb87d74072b4c86e

from violation-comments-to-stash-plugin.

tomasbjerre avatar tomasbjerre commented on June 21, 2024

I just released this. Should be in the Jenkins update center within a few hours.

from violation-comments-to-stash-plugin.

tuukkamustonen avatar tuukkamustonen commented on June 21, 2024

Thanks, I'll give it a spin tomorrow!

from violation-comments-to-stash-plugin.

tuukkamustonen avatar tuukkamustonen commented on June 21, 2024

It seems to work, but it be possible to include also the "numeric" rule ID into Rule field:

Found 1 violation:
Reporter: PYLINT
Rule: anomalous-backslash-in-string
Severity: WARN
File: fs/csm/admin_api/admin_api.py L1086

Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>

Normally you discuss/ignore/google per rule ID (e.g. E1101) rather than it's label. Perfect output would be something like:

Rule: W1401(anomalous-backslash-in-string)

from violation-comments-to-stash-plugin.

tomasbjerre avatar tomasbjerre commented on June 21, 2024

Should be fixed in 1.31!

from violation-comments-to-stash-plugin.

tomasbjerre avatar tomasbjerre commented on June 21, 2024

I just realized I missed the severity level... I'll fix that later.

from violation-comments-to-stash-plugin.

tomasbjerre avatar tomasbjerre commented on June 21, 2024

Open issue again if not fixed!

from violation-comments-to-stash-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.