Git Product home page Git Product logo

Comments (9)

ndeloof avatar ndeloof commented on July 18, 2024

we could rely on AdminWhitelistRule#setMasterKillSwitch(), but need some way to define a yaml path to this extension. We can't just expose all extensions, need to define which ones have to be included and how to.

I wonder why AdminWhitelistRule is not exposed as a ManagementLink or something similar. I don't even know how one access it's configuration UI, can't find this in UI menus

from configuration-as-code-plugin.

ndeloof avatar ndeloof commented on July 18, 2024

ok, this is actually managed by jenkins.security.s2m.MasterKillSwitchConfiguration without an explicit setter and manual databinding. So can't be supported out-of-the-box and will require some glue code (or fix in core)

from configuration-as-code-plugin.

odavid avatar odavid commented on July 18, 2024

The UI is in "Configure Global Security/Enable Agent → Master Access Control"

from configuration-as-code-plugin.

ndeloof avatar ndeloof commented on July 18, 2024

yes, indeed. But this UI is exposed by MasterKillSwitchConfiguration which delegates to AdminWhitelistRule. There's few places where such a pattern applies, mostly for backward compatibility. I think we should get some @ManagedBy or @DelegateTo annotation to document this and make this discoverable by introspection.

from configuration-as-code-plugin.

odavid avatar odavid commented on July 18, 2024

I was referring to your comment that you could not find it in the UI menus.
I understand it requires some changes in core. This is why I raised this issue instead of creating PR (: . Regards,
Ohad

from configuration-as-code-plugin.

oleg-nenashev avatar oleg-nenashev commented on July 18, 2024

Working on it, important for remoting

from configuration-as-code-plugin.

oleg-nenashev avatar oleg-nenashev commented on July 18, 2024

It would be great to merge it for jenkinsci/jenkins#2930

from configuration-as-code-plugin.

oleg-nenashev avatar oleg-nenashev commented on July 18, 2024

@odavid Created #90

from configuration-as-code-plugin.

odavid avatar odavid commented on July 18, 2024

Thanks @oleg-nenashev.

from configuration-as-code-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.