Do you need core-js? about vue-modal HOT 6 CLOSED

Hmm, adding hooks take more time...
I read npm's documentation and find that dependencies is a list of package that used in module(For example import {something} from something;), devDep is a modules that using for development: linters, tests or other
I use only vue, so removing core-js is right!
Thnx!

from vue-modal.

Hello!
By default, when I create a blank project using vue-cli, it adds two deps: core-js and vue.
Core is being a scope of polyfills. I think that we use core-js (or some other vue's library, like vue-service), because after removing core-js form package. json and install clean project I find the core-js library in node-modules.

In result, I remove core-js from dependencies. Thanks @ina6ra

from vue-modal.

Some modules in npm have next config

They put vue in peer dependence, but i will save vue in main dependence(i dont think that it will helpfull, what do you think?)

from vue-modal.

Confirmed in a new project.

$ vue --verion
@vue/cli 4.5.13
$ vue create my-project
> Default (Vue 3) ([Vue 3] babel, eslint)
$ cd my-project
$ npm ls vue
`-- [email protected]
$ npm ls core-js
+-- @vue/[email protected]
| `-- @vue/[email protected]
|   `-- [email protected]  deduped
`-- [email protected]
$ yarn add jenesius-vue-modal
$ npm ls vue
+-- [email protected]
| `-- [email protected]  deduped
`-- [email protected]
$ npm ls core-js
+-- @vue/[email protected]
| `-- @vue/[email protected]
|   `-- [email protected]  deduped
`-- [email protected]

In addition to core-js, there were duplicate vue that I did not use.

Both are not mentioned in vue-js-modal, so I think you can delete both.
https://www.npmjs.com/package/vue-js-modal

Since vue-js-modal uses resize-observer-polyfill, it is Dependencies,
but jenesius-vue-modal does not use it, so I don't think you need it either.
https://github.com/euvl/vue-js-modal/search?q=resize-observer-polyfill

from vue-modal.

i will today test library without vue-cli
And then write summary

from vue-modal.

Thanks @Jenesius
I confirmed that it was supported in version 1.0.14.

from vue-modal.