Type Supporting about vue-modal HOT 10 CLOSED

For setup component is contuine don't worked.

from vue-modal.

I found next solution but its not work for me: link.
Trying found something else.

from vue-modal.

type SimpleComponent<T> = {
    props?: T,
    [name: any]: any
}

export default function openModal<P extends SimpleComponent<T>, T>(component: P, props: T, options: PartialModalOptions = {}):Promise<Modal>

But in current solution props is required. Need to fix it.

from vue-modal.

Changes:

type SimpleComponent<T = {}> = Component &  {
    props?: T,
}

export default function openModal<P extends SimpleComponent>(component: P, props: P["props"] | UnwrapRef<P["props"]> = {}, options: PartialModalOptions = {}):Promise<Modal>
{
    return closeModal()
   .then(() => {
       if (modalQueue.value.length) throw ModalError.QueueNoEmpty();
   })
    .then(() => pushModal(component, props, options))
}

Now is working. Continue with fixs and tests

from vue-modal.

Is not working for default vue component(without typescipt annotation)

TS2322: Type 'number' is not assignable to type 'NumberConstructor'.
    11 |                let output = null;
    12 | 
  > 13 |                const modal = await openModal(ModalButton, {value});

Maybe ExtractPropTypes will helpfull..

from vue-modal.

I Stopped on providing computed and ref values to modals. I think is main func and should be suported by library

from vue-modal.

Recomendation
WebStorm bug

from vue-modal.

Done! But I think it will work not for everyone. Need check it for big project

from vue-modal.

After adding ComputedRef/ Ref I see the next problem:

After declaration types the TS provide me props and ComputedValues: value or effect

from vue-modal.

I will merge current branch today after testing. Also I will update preview GIF and add design pack.

from vue-modal.