Comments (10)
For setup component
is contuine don't worked.
from vue-modal.
I found next solution but its not work for me: link.
Trying found something else.
from vue-modal.
type SimpleComponent<T> = {
props?: T,
[name: any]: any
}
export default function openModal<P extends SimpleComponent<T>, T>(component: P, props: T, options: PartialModalOptions = {}):Promise<Modal>
But in current solution props is required. Need to fix it.
from vue-modal.
Changes:
type SimpleComponent<T = {}> = Component & {
props?: T,
}
export default function openModal<P extends SimpleComponent>(component: P, props: P["props"] | UnwrapRef<P["props"]> = {}, options: PartialModalOptions = {}):Promise<Modal>
{
return closeModal()
.then(() => {
if (modalQueue.value.length) throw ModalError.QueueNoEmpty();
})
.then(() => pushModal(component, props, options))
}
Now is working. Continue with fixs and tests
from vue-modal.
Is not working for default vue component(without typescipt annotation)
TS2322: Type 'number' is not assignable to type 'NumberConstructor'.
11 | let output = null;
12 |
> 13 | const modal = await openModal(ModalButton, {value});
Maybe ExtractPropTypes will helpfull..
from vue-modal.
I Stopped on providing computed and ref values to modals. I think is main func and should be suported by library
from vue-modal.
from vue-modal.
Done! But I think it will work not for everyone. Need check it for big project
from vue-modal.
After adding ComputedRef/ Ref I see the next problem:
After declaration types the TS provide me props and ComputedValues: value or effect
from vue-modal.
I will merge current branch today after testing. Also I will update preview GIF and add design pack.
from vue-modal.
Related Issues (20)
- Nuxt compatibility HOT 7
- Dialog - backgroundClose: true - mouseup HOT 7
- Vue Warn deprecation TRANSITION_GROUP_ROOT HOT 5
- Version 2.0.0 HOT 3
- How to pass values back from modal component to parent HOT 4
- [BUG] На сайте кнопка Следующая страница всегда ведет на первую HOT 2
- promptModal produce promise cannot go next step when call openModal HOT 10
- modal cannot open when give namespace HOT 3
- problems using namespace with pushModal HOT 4
- click on the title, hold and drag HOT 32
- How can I pass the slot HOT 2
- There is an onBeforeModalClose, can you add an onBeforeModalOpen? HOT 14
- Add appear prop on transition-group for correct animation for defineAsyncComponent HOT 2
- Are there any plans to add an option to have ESC close the dialog even if a namespace is specified? HOT 3
- Does `scrollLock` not work if a namespace is specified?
- When multiple pop-up modal are opened at the same time, how to ensure that only one is displayed at a time and the one behind it is closed? HOT 10
- Vue.use(Modal) support? HOT 12
- Create multiple instances HOT 6
- Gaurd return false.Modal navigation was stoped. HOT 4
- Open Modal Vue 3 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vue-modal.