jemt / paymentserviceproviderinterface Goto Github PK

I get

Notice: Undefined index: ConfigPath in .../PSPI/PSPInterface.php on line 410
Notice: Undefined index: ConfigPath in .../PSPI/PSPInterface.php on line 412

in ensureBaseConfig..

The security check in GetCallbackData is much welcome. However the small portion of $_POST data returned is problematic if you are working with provider specific return values (such as status codes).

Perhaps you could add another entry ("InternalData" or "PostData") to the associative array result and simply dump $_POST there)

DIBS return various status codes which are useful for debugging and order process updates.

PSPI could implement a method for mapping the typical codes across payment providers (PayPal codes are not that different from DIBS' codes).

http://tech.dibspayment.com/nodeaddpage/toolboxstatuscodes

// 0 transaction inserted
// 1 declined
// 2 authorization approved
// 3 capture sent to acquirer
// 4 capture declined by acquirer
// 5 capture completed
// 6 authorization deleted
// 7 capture balanced
// 8 partially refunded and balanced
// 9 refund sent to acquirer
// 10 refund declined
// 11 refund completed
// 12 capture pending
// 13 "ticket" transaction
// 14 deleted "ticket" transaction
// 15 refund pending
// 16 waiting for shop approval
// 17 declined by DIBS
// 18 multicap transaction open
// 19 multicap transaction closed

The implementation of PSP::GetConfig($provider) is inconvenient. It is not possible to load the configuration for two different providers within the same script - the first provider configuration requested will always be returned due to a static reference.

$dibs = PSP::GetConfig("DIBS") // Returns DIBS PSPM as expected
$paypal = PSP::GetConfig("PayPal") // BUG: Returns DIBS PSPM even though PayPal was expected

To use the modern responsive DIBS payment window, add this parameter to the form:

<input type="hidden" name="decorator" value="responsive">