Changes to files starting with _site are not being picked up about jekyll-watch HOT 22 CLOSED

Chiming to add my "me too". Just ran across this with a Jekyll template that I've been working with.

from jekyll-watch.

Yeah, this has never been fixed. Last time I tried, it still wasn’t working.

from jekyll-watch.

I don't think so. I worked on that a while back but eventually got stuck. Basically, the root _site should be matched for the exclude, not everything starting with _site.

from jekyll-watch.

This is because we're using regexp and have no special handling. I'd love to make this more like .gitignore

from jekyll-watch.

If someone sees this and wants to fix it, check out Listen's ignore directive. Right now we use regexp that basically just does a substring lookup.

from jekyll-watch.

I just forked this thing and tinker around a bit. I see that listen_ignore_paths returns something like a list containing _config.yml and _site (no other ignore paths passed). Am I right that everything containing these strings is currently not being watched? Whats the strategy here, then? We should a) only ignore the _config.yml file and b) ignore the whole _site directory.

Somehow, I currently run into a regeneration loop as soon as I touch a file that is not ignored.

from jekyll-watch.

Seems a little bit more complicated. I'm not sure how the can tell listen to ignore a directory. Can we distinguish between files and directories? Files would need something like /^filename\.ext$/ for an exact match. But directories? We only want to ingore that one _site directory. Nothing else containing this string.

from jekyll-watch.

I also stumbled over this rather mean bug. My workaround is to export to _tmp.

from jekyll-watch.

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If you can still reproduce this error on the 3.1-stable or master branch,
please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced
hooks which provide convenient access points throughout
the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be
built as a plugin, then please provide more information about why in order to keep this issue open.

Thank you for all your contributions.

from jekyll-watch.

@kleinfreund Thanks for the reply! This may simply be a limitation of the way jekyll-watch works. Would it be enough to indicate change detected for '_sass/_site-head.scss' but matches exclude rule /_site/; ignored? Perhaps this could be fixed with a simple UX change.

from jekyll-watch.

This issue has been automatically marked as stale because it has not been commented on for at least one month.

The resources of the Jekyll team are limited, and so we are asking for your help.

If you can still reproduce this error on the 3.1-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.

Thank you for all your contributions.

from jekyll-watch.

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

from jekyll-watch.

Adding a "me too". This bit me and killed some time figuring out.

from jekyll-watch.

I stumbled across the same issue and spent nearly 3 hours figuring out what was going on. Basically I had excluded a file called 'start' long ago. Today I created a folder called 'getting-started' and noticed that jekyll-watch was ignoring it during incremental builds. After lot of investigation, I stumbled upon this thread and figured out the problem. Is there a way to specify an exact match instead of a substring match in the exclude list?

from jekyll-watch.

This issue is not resolved. It needs to reopened.

from jekyll-watch.

Anchoring the regexp should help here.

from jekyll-watch.

@kleinfreund et al, Would you guys be willing to test a fix for this..? Simply, add the following to your Gemfile, if interested.. Thanks in advance. 😃

# Gemfile

gem "jekyll-watch" , :git => "https://github.com/ashmaroli/jekyll-watch.git", :branch => "ignore-directory-paths"

from jekyll-watch.

Apologies for the late response. I'm willing to test it. But can you explain how the fix is going to work so that I know what to test?

from jekyll-watch.

@deepfriedbrain You can start by testing if your issue is resolved.. i.e., if you exclude a 'file' called start, does jekyll-watch ignore changes to contents of getting-started folder..

Then you can test if the plugin ignores changes to a file with the relative-path _includes/_site-head.html and so on..

from jekyll-watch.

It seems to be working well based on my testing.

from jekyll-watch.

Was this fixed? Can the issue be closed?

from jekyll-watch.

@kleinfreund not yet, #65 is still pending for review

from jekyll-watch.