jekader / openvpn-iptables Goto Github PK

This is a request to add iroute definition parsing to the script.

All "iroute" networks should be allowed to access all "route" destinations for the specific connection.

At the moment file locking is sub-optimal and rules may be accidentally added while they're being by another thread. As rules are removed by line number, this will cause line numbers to shift and wrong rules to be removed.

currently it's not clear that the default policy should deny all leftover traffic,

Currently on_disconnect.sh only checks for rules to be removed by grepping for the $common_name"_openvpn"

This may cause issues.

Steps to reproduce:

1. create users "testuser" and "anothertestuser"
2. connect both users
3. disconnect "testuser"

Actual result:
rules are removed for both users as the script greps for "testuser_openvpn" which will also match "
"anothertestuser_openvpn"

Expected results:
just rules for the right user are removed

Proposed solution:
add a prefix and grep for a string including it:
"rules_"$common_name"_openvpn"