Comments (14)
@jeanpan, there's another issue. The selected state is kept despite new selected
props being passed in. perhaps it needs a componentWillReceiveProps
to update state.
from react-native-camera-roll-picker.
@ndao. I will prepare a commit for preserving the state by passing an array of selected image as a props to the component and setting this props as the default value of selected state.
from react-native-camera-roll-picker.
@ndao. Now you can pass a selected array as a props to the component, as the example here https://github.com/jeanpan/react-native-camera-roll-picker/blob/master/Example/index.ios.js#L50 to preserve the selected state. Let me know if this solve your problem.
from react-native-camera-roll-picker.
@jeanpan wow that was fast! thanks so much!
Question: in the latest version, the callback
now returns an array of Objects
whereas before it was returning an array of string
. As they're objects now, this won't return the right index https://github.com/jeanpan/react-native-camera-roll-picker/blob/master/index.js#L159
to satisfy the selected state.
it is breaking for me. thoughts?
from react-native-camera-roll-picker.
@ndao. Yes, before the callback
returns an array of string ( image uri ) but now it returns an array of Objects
( image object ). The indexOf
works fine for me. Is your selected state a object array or a string array ? Could you please provide me your code so I can help you to fix the problem ?
from react-native-camera-roll-picker.
@jeanpan, i am basically using Redux to store the objects that returned from callback
and pass it back again to CameraRollPicker component
Below is what the array of objects looks like
like so
<View
style={{flex: 1, flexDirection: 'column'}}>
<CameraRollPicker
groupTypes='All'
maximum={15}
assetType='All'
imagesPerRow={3}
imageMargin={5}
selectedMarker={<Marker />}
selected={selected}
callback={this.props.attachPhotos} />
</View>
from react-native-camera-roll-picker.
it also looks like the Camera component adds the selected
array that i am passing in to its state (but not showing those images are selected). it then returns all the newly selected items PLUS the selected array items that was passed in.
from react-native-camera-roll-picker.
@ndao It seems there is something wrong with selected state. I will fix it asap. Thanks for the comments.
from react-native-camera-roll-picker.
@ndao I fixed the problem in the latest version ( 1.1.5 ). Please check it and let me know if there is any problem. Thanks !
from react-native-camera-roll-picker.
looks like 1.1.5 fixed it! thanks so much!
from react-native-camera-roll-picker.
@ndao ok. Will fix it asap. Thanks!
from react-native-camera-roll-picker.
@ndao Fixed at the latest version 1.1.6. Please let me know if there is any question. Thanks !
16991b5
from react-native-camera-roll-picker.
thanks @jeanpan,
fyi there are some warnings with the SGListView stuff
from react-native-camera-roll-picker.
@ndao Thanks for the fyi. I will created another issue to track the warnings of SGListView.
from react-native-camera-roll-picker.
Related Issues (20)
- How to restrict image picker to show images from specific gallery folder (DCIM/Camera)
- Need a changelog for v2 HOT 2
- Cannot read property of 'getPhotos' of underfined HOT 2
- Doesn't work for vidoes assetType
- Can we open camera from photo list page?
- Still get CameraRoll error even after reinstalling the package to newer version
- Callback function no longer returns the same data HOT 1
- Absolute Path not found HOT 1
- Null is not an object evaluating _nativeInterface.default.getPhotos
- Add support for groupTypes and groupName
- Images not rendering on Huawei phones
- Infinite loop on pixel phone
- Sealed this.state.selected array
- Update ListView to Flatlist HOT 3
- Need to show Image folders
- prop remove selectedMarker HOT 1
- Is it work now? HOT 2
- render() method in imageItem.js is calling N number of times
- Upgrade to latest react native HOT 1
- TypeError: Cannot read property 'getPhotos' of undefined HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-camera-roll-picker.