Git Product home page Git Product logo

Comments (14)

ndao avatar ndao commented on May 30, 2024 1

@jeanpan, there's another issue. The selected state is kept despite new selected props being passed in. perhaps it needs a componentWillReceiveProps to update state.

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao. I will prepare a commit for preserving the state by passing an array of selected image as a props to the component and setting this props as the default value of selected state.

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao. Now you can pass a selected array as a props to the component, as the example here https://github.com/jeanpan/react-native-camera-roll-picker/blob/master/Example/index.ios.js#L50 to preserve the selected state. Let me know if this solve your problem.

from react-native-camera-roll-picker.

ndao avatar ndao commented on May 30, 2024

@jeanpan wow that was fast! thanks so much!
Question: in the latest version, the callback now returns an array of Objects whereas before it was returning an array of string. As they're objects now, this won't return the right index https://github.com/jeanpan/react-native-camera-roll-picker/blob/master/index.js#L159
to satisfy the selected state.
it is breaking for me. thoughts?

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao. Yes, before the callback returns an array of string ( image uri ) but now it returns an array of Objects ( image object ). The indexOf works fine for me. Is your selected state a object array or a string array ? Could you please provide me your code so I can help you to fix the problem ?

from react-native-camera-roll-picker.

ndao avatar ndao commented on May 30, 2024

@jeanpan, i am basically using Redux to store the objects that returned from callback and pass it back again to CameraRollPicker component
Below is what the array of objects looks like
image
like so

<View
        style={{flex: 1, flexDirection: 'column'}}>
          <CameraRollPicker
            groupTypes='All'
            maximum={15}
            assetType='All'
            imagesPerRow={3}
            imageMargin={5}
            selectedMarker={<Marker />}
            selected={selected}
            callback={this.props.attachPhotos} />
      </View>

from react-native-camera-roll-picker.

ndao avatar ndao commented on May 30, 2024

it also looks like the Camera component adds the selected array that i am passing in to its state (but not showing those images are selected). it then returns all the newly selected items PLUS the selected array items that was passed in.

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao It seems there is something wrong with selected state. I will fix it asap. Thanks for the comments.

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao I fixed the problem in the latest version ( 1.1.5 ). Please check it and let me know if there is any problem. Thanks !

from react-native-camera-roll-picker.

ndao avatar ndao commented on May 30, 2024

looks like 1.1.5 fixed it! thanks so much!

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao ok. Will fix it asap. Thanks!

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao Fixed at the latest version 1.1.6. Please let me know if there is any question. Thanks !
16991b5

from react-native-camera-roll-picker.

ndao avatar ndao commented on May 30, 2024

thanks @jeanpan,
fyi there are some warnings with the SGListView stuff
image

from react-native-camera-roll-picker.

jeanpan avatar jeanpan commented on May 30, 2024

@ndao Thanks for the fyi. I will created another issue to track the warnings of SGListView.

from react-native-camera-roll-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.