jeannetoh99 / pe Goto Github PK

Sample archived clients could be provided the same way sample active clients are provided.

As seen from the screenshot, on start up there are no sample archived clients to work with.

This is quite unrealistic, since many clients usually hold more than one policy with an insurance company.

The following diagram was in both page 3 and page 5 of the DG. Perhaps you could use referencing instead.

There should be an operation PersonCard() labelled in the arrow pointing to the PersonCard during object creation.

There are no commands provided to edit the client details. This will be inconvenient for the user if the client's email address or phone number changes.

Type the following command:

Person is added even though email address' domain name is invalid. This however follows the UG specifications, but I think it is a feature flaw since these forms of invalid email addresses are not accounted for.

Similar to previous issue.

Not sure if this is a UG bug or functionality bug, but functionality does not work as specified in the UG.

Steps to Reproduce:

Add 2 clients with the same name, phone number but different email address.
Expected: Both clients added (since UG states that 2 clients are considered different if they have different names OR they have the same name BUT have different email or phone number)

Actual: Error thrown, marked as duplicate client

Screenshots:

Steps to Reproduce:

1. Type command: list abc
   Expected: error thrown
   Actual: lists all active persons
   Screenshots:
   

Same for listing archives

1. Type command: list r/a
   Expected: error thrown
   Actual: lists all archived persons
   

The following restrictions were not documented in the UG but shown in error message only.

This is especially inconvenient since clearp clears all the policies in the policy list, leaving clients without and policies. Furthermore, clients cannot be edited (no command for that). This renders the app quite unusable. Since existing client data cannot hold any policies after clearp.

The terms "active mode" and "archive mode" are used several times in the UG without an official definition.

There is the following:
In the “active mode”, users can view the active list. In the “archive mode”, users can view the archive.

However, this does not address that list switches to "active mode" and list r/ switches to "archive mode".

Took me awhile to understand that the modes refers to when we use list and list r/ respectively. Maybe this can be explained at the start, as well as under the 'Listing all active clients' and 'Listing all archived clients' respectively.

Not sure if this is a UG bug or functionality bug, but functionality does not work as specified in the UG.

Steps to Reproduce:

1. Add 2 clients with the same name, email address but different phone number.

Expected: Both clients added (since UG states that 2 clients are considered different if they have different names OR they have the same name BUT have different email or phone number)

Actual: Error thrown, marked as duplicate client

Screenshots:

The following command is accepted:

add n/May p/98765432 e/[email protected] a/123 street pn/Life Time Policy

After deleting the previously added client,

The following command is not accepted, as policy name is not found.

add n/May p/98765432 e/[email protected] a/123 street pn/life time policy

This can be quite inconvenient. It would be easier to have the policy name case insensitive, or better still, refer to them via an index.

As shown:

Can use page breaks

The label 'filtered list' between ModelManager and Person is neither a role (since it's in the middle) nor an association label (since it is missing the triangle).

The error message here has 6 lines, but the box only shows 3 lines. Additional scrolling is required which is inconvenient for a CLI-user/ fast-typist since they need to scroll.

Under "Adding a client", the policy name parameter is included.

However, under "Command summary", the policy name parameter is excluded under the format for Add.

No commands to view existing policies in the list. This makes it very inconvenient to keep track of policies available, and even to add policies to clients since you need to memorise the names of policies available.

Policies are constantly changing in an issurance company. It is very inconvenient if the policies cannot be edited or deleted individually, but can only be added individually/ cleared entirely.