jeanbza / git-go-websiteskeleton Goto Github PK

Because this is intended to be installed in $GOPATH/src, godoc can't install it. This may represent a deeper problem - if the go community is making apps that assume installations under $GOPATH/src/, then perhaps we should just adhere to that.

You are setting the title in Page, but you aren't using it in the layout.html. Is that intentional?

Suggestion from community - needs to be looked into:

• You shouldn't reload/reparse templates at each request.
• You should render/execute your template on a byte buffer, then copy that buffer to the http.ResponseWriter. Otherwise you will lose either IO errors or template errors. Either way, a bad idea.

Example: http://www.gorillatoolkit.org/pkg/mux

Hey man, first of all I love the project. Have been using it to learn Go web development and it's been a big help.

I noticed a few flaws in your server access logging and wanted to point them out.

Your access logger takes a response writer, but it's never actually used. So the value for responseBytes is never set or reported, and the status will always be http.StatusOK regardless of what the actual status is.

I think some confusion might have arisen from trying to incorporate gorilla/mux, but the router return from mux.NewRouter actually implements the interface http.Handler and so the code from https://gist.github.com/cespare/3985516 can actually be used pretty much as -is.

I've written up my own gist demonstrating that. It's filled with comments to myself as I was going through both of your implementations line by line and I think it may prove helpful.
https://gist.github.com/pathouse/e74f9dc7919dd9f0ca88

As suggested:

template.Must() returns a pointer to a Template type which is cached (stored in RAM). You can execute content on this type with calling the pointer and calling the method ExecuteTemplate().
It is shown here: http://golang.org/doc/articles/wiki/#tmp_10
What you are doing is creating the same Template type over and over again with each request.

Readme installation instructions are contradictory to How to Write Go Code - Workspaces

main.go imports will need to be updated to correct for $GOPATH difference

Things like:

import (
    "git-go-websiteskeleton/src/home"
)

See http://golang.org/doc/code.html#GOPATH

This will allow easier deployment - as in, on a dev box you could use :8080 but a prod box might use :80.

There was no logging package 2 years ago :)