jdupuy / dj_brdf Goto Github PK

I was wondering whether one could easily extend this to other BRDF data file formats.

In my concrete case it looks like one should be able to create a new class ISSA which would get a constructor loading data from Radiant's *.bsdf file and a BRDF lookup method ISSA::eval(), right?

Before I experiment any further with this: Which license has this code?

Hi Jonathan,

I've come across a possible problem with the definition of theta_d. The code in the repo as well as in Listing 2.2 of your thesis makes clear that theta_d is the angle between the outgoing vector and the halfway vector.

But Rusinkiewicz's paper relates it to the incoming vector, as can be seen in his Figure 2.

Citing page 4, end of last paragraph:

The two rotations in equation 9 bring the halfangle h to the north pole, and (theta_d , phi_d) are the spherical coordinates of the incident ray in this transformed frame.

I guess his document must be at fault* and not your thesis, right?! :-)

Greets, Marko

*) perhaps being just a preliminary text and not the finally published version