jdtuck / fdasrvf_r Goto Github PK

Hi,

thank you for that nice R package!
However, I found a certain issue in the code of the function srsf_to_f:

The norm of the sqv-function in the multidimensional case is defined as qnorm = abs(q[, i]) , which must be qnorm = sqrt(crossprod(q[, i])).

Best,
Almond

The version on CRAN has the issue of non-zero distance (cal_shape_dist) between a curve and itself. For example, calc_shape_dist(beta[,,1,1],beta[,,1,1]) = 0.000133296. Could you please look into this issue?

Regards,
Pankaj

In the process of documenting and improving code coverage, I noticed that a lot of dependencies of fdasrvf are actually imported for the use of a single function. This is true for lpSolve, Matrix, mvtnorm, tolerance and viridisLite. It could be good to think about in-house replacement for these functions which would lead to removing these dependencies.

Similarly,

• only two functions of coda are used;
• only three functions of fields are used

but these are more specialised and might not be trivial to rewrite on our own.

The following code doesn't work for me:
librayr(fdasrvf)
out <- calc_shape_dist(beta[, , 1, 1], beta[, , 1, 4], mode = "C")

Error in f[, (tau + 1):T1] : subscript out of bounds

mode = "O" works fine, but mode = "C" gives me that error.

In the next R 4.3.0 version, CRAN will request that any package requiring C++ in the SystemRequirements entry of the DESCRIPTION file defaults to C++17. There are two ways of handling this. If your package does not actually use syntax from either C++11 of C++14 or C++17, then we could remove the requirement completely as it is currently being done for many tidyverse-related packages or Rcpp-related packages.
Otherwise we will need to update to C++17.