jdesrosiers / silex-jms-serializer-provider Goto Github PK

I wonder how i can add a custom Visitor that extends the JsonDeserializationVisitor. The constructor of JsonDeserializationVisitor requires an instance of PropertyNamingStrategyInterface, but i can't access it within the configuration because 'serializer.namingStrategy' is not added to Pimple if it is not defined as an configuration option.

$app->register(new JmsSerializerServiceProvider(), [
  // 'serializer.namingStrategy' => new CamelCaseNamingStrategy(),
  'serializer.deserializationVisitors' => [
    'json' => new StrictJsonDeserializationVisitor($app['serializer.namingStrategy']), // fails, key is missing
  ]
]);

The example above works if i set the naming strategy and overwrite the default one, but it fails if i don't set it, because 'serializer.namingStrategy' will never be set.

Looking at the source of SerializerBuilder it is inteded by JMS, that addDefaultSerializationVisitors() is only called if no custom serializationVisitors are registered, to be able to have none of the default serialization visitors to be added.

This means the default behavior of the builder is, that it only registers defaults if no other visitors are registered first. But JmsSerializerServiceProvider calls addDefaultSerializationVisitors() within setSerializationVisitors. Same goes for DeserializationVisitors.

// JmsSerializerServiceProvider.php
    protected function setSerializationVisitors(Container $app, SerializerBuilder $serializerBuilder)
    {
        // Adds defaults, even if visitors are defined by the config
        $serializerBuilder->addDefaultSerializationVisitors();

        foreach ($app["serializer.serializationVisitors"] as $format => $visitor) {
            $serializerBuilder->setSerializationVisitor($format, $visitor);
        }
    }

// SerializerBuilder.php->build()
        if ( ! $this->visitorsAdded) { // Avoids adding defaults if visitors are added manually.
            $this->addDefaultSerializationVisitors();
            $this->addDefaultDeserializationVisitors();
        }

The solution would be to remove the call to addDefaultSerializationVisitors(). It is done anyway by the builder if no visitors are defined.