jd-wang / pinia-persistedstate Goto Github PK

When rehydrating/merging the persisted data for the stores it is corrupting the local storage and store. I have 3 stores named common, crm-dashboard, and deal. We are configured to only persist common and deal.stages.

Here's my config:

  store.use(
    persistedstate({
      overwrite: true,
      paths: ['common', 'deal.stages']
    })
  )

1. I'll delete Pinia from the browser local storage. Here's local storage after deleting it.

2. I'll do a CTRL+F5 to force a full refresh.

We now have a legit local storage for Pinia.

That all looks correct. It contains only the things we've configured (via option.paths) to persist.

Likewise, the Pinia store looks correct using the Chrome Vue extension.

Here's the deal store state, which is correct.

Here's the common store state, which is correct.

3. Now I'll do an F5 to refresh.

The first indication of trouble is that local storage is now corrupted. Notice that nested in the common store are the common and deal stores!

And so too are the deal and common stores.

I'm using version 0.1.2 of pinia-persistedstate.

$ npm list pinia-persistedstate

[email protected] C:\development\CRMDealsWebApp
`-- [email protected]

From the doc:

paths : An array of any paths to partially persist the state. If no paths are given, the complete state is persisted. If an empty array is given, no state is persisted.

Yet the code returns the entire state if the paths array is empty.

  function reducer(state, paths: Array<string>) {
    return isNotEmptyArray(paths)
      ? paths.reduce(function (substate, path) {
          return shvl.set(substate, `${path}`, shvl.get(state, path))
        }, {})
      : state
  }

Additionally, I'm not sure enough distinction is made between persisting (to local) storage vs loading/observing? I might be wrong about that though. I say this because stuff is persisted to local storage that I don't think should be based on when I have provided paths so wondering if everything in the store gets persisted to local storage but then gets pruned via reducer on load? So it IS persisted, just reduced back out on load maybe?